Pending tips processing can continue indefinitely for cross-provider tips

[zenparsing]

Description

When a pending tip is added for a creator where:

• The creator is verified with provider A
• And the user is verified with provider B

the pending tip processor can get into a loop where it continually retries the pending tip every 30 seconds or so.

Steps to Reproduce

With a clean profile:

1. Verify with a wallet provider (e.g. Uphold).
2. Visit a site that is verified with a different provider (e.g. https://jumde.github.io/ verified with Gemini).
3. Send a one-time tip.
4. Open the publisher_info_db database and view the pending_contribution table.

Actual result:

The pending_contribution_id field will keep incrementing.

Expected result:

The pending_contribution_id field will not keep incrementing.

[kjozwiak]

Moving this into 1.34.x as per the discussion we had on Tuesday's b-b meeting. It doesn't seem like we'll get another C96 before we release 1.34.x with C97. However, if we do end up getting another C96 and it ends up fixing a zero day security issue, we'll re-create a 1.33.x - Release #2 milestone and move this issue back as it's already in the 1.33.x branch.

[stephendonner]

Verified PASSED using

Brave	1.34.77 Chromium: 97.0.4692.56 (Official Build) (64-bit)
Revision	04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS	Windows 10 Version 20H2 (Build 19042.1415)

Steps:

1. new profile
2. launched Brave using Rewards staging
3. enabled Rewards
4. clicked to Verify Wallet with Uphold and confirmed I was verified
5. loaded https://jumde.github.io/
6. sent a (few) one-time tip(s)
7. opened the publisher_info_db database and viewed the pending_contribution table

Confirmed with @zenparsing that the above is correct (see screenshots); the pending_contribution table does not keep incrementing (retrying).

example	example	example	example	example	example	example