Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private with Tor should just read Tor in New private window with Tor #20118

Closed
stephendonner opened this issue Dec 15, 2021 · 3 comments · Fixed by brave/brave-core#11671
Closed

Comments

@stephendonner
Copy link

Description

Private with Tor should just read Tor in New private window with Tor

Per #13704.

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. click on the "hamburger" menu on the browser toolbar
  4. choose New private window with Tor
  5. examine the icon and text to the right of the URL bar

Actual result:

13704-3

Expected result:

Should just read Tor, according to #13704

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.34.63 Chromium: 96.0.4664.110 (Official Build) beta (64-bit)
Revision d5ef0e8214bc14c9b5bbf69a1515e431394c62a6-refs/branch-heads/4664@{#1283}
OS Windows 10 Version 20H2 (Build 19042.1415)

cc @nullhook @rebron

@rebron
Copy link
Collaborator

rebron commented Dec 17, 2021

cc: @diracdeltas Wanted to double check this is ok, going from Private window with Tor to just Tor. It's a follow-up to #13704 to make some room in the toolbar.

@diracdeltas
Copy link
Member

sgtm

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.36.22 Chromium: 97.0.4692.71 (Official Build) nightly (x86_64)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS macOS Version 11.6.1 (Build 20G224)

Followed my original steps to reproduce, and confirmed the Private with Tor button text now reads simply Tor.

Screen Shot 2022-01-07 at 8 17 51 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants