Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet add account and add asset popups should dismiss if Esc is pressed #20164

Closed
bbondy opened this issue Dec 19, 2021 · 4 comments · Fixed by brave/brave-core#11646
Closed

Wallet add account and add asset popups should dismiss if Esc is pressed #20164

bbondy opened this issue Dec 19, 2021 · 4 comments · Fixed by brave/brave-core#11646
Assignees
@muliswilliam
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.35.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Dec 19, 2021

If you press escape after one those poups happen nothing happens.
Instead they should dismiss.
cc @muliswilliam
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 19, 2021
@muliswilliam
Copy link

@bbondy I will pick this up.

@muliswilliam muliswilliam self-assigned this Dec 20, 2021
@muliswilliam muliswilliam mentioned this issue Dec 20, 2021
Merged
25 tasks
@muliswilliam muliswilliam added this to the 1.35.x - Nightly milestone Dec 20, 2021
@bbondy
Copy link
Member Author

bbondy commented Dec 21, 2021

Thank you!

@stephendonner
Copy link

Verified PASSED using

Brave 1.35.69 Chromium: 97.0.4692.56 (Official Build) dev (x86_64)
Revision 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS macOS Version 11.6.1 (Build 20G224)

Confirmed using esc closes dialogs/popups, as seen below:

escape-to-close

@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label Jan 7, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.35.82 Chromium: 97.0.4692.71 (Official Build) beta (64-bit)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS Windows 11 Version Dev (Build 22523.1000)
  • Verified steps from brave/brave-core#11646
  • Verified Add wallet modal is dismissed when Esc is pressed
  • Verified Add wallet modal on Import and Hardware Wallet tabs can also be closed via Esc
  • Verified Visible assets modal can be closed via Esc button
  • Verified Visible assets modal with Add custom token view can also be closed via Esc button

Verification passed on

Brave 1.35.82 Chromium: 97.0.4692.71 (Official Build) beta (64-bit)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS Linux
  • Verified steps from brave/brave-core#11646
  • Verified Add wallet modal is dismissed when Esc is pressed
  • Verified Add wallet modal on Import and Hardware Wallet tabs can also be closed via Esc
  • Verified Visible assets modal can be closed via Esc button
  • Verified Visible assets modal with Add custom token view can also be closed via Esc button

@kjozwiak kjozwiak mentioned this issue Feb 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.35.x - Release
Development

Successfully merging a pull request may close this issue.

Close model when Esc key is pressed brave/brave-core
5 participants
@stephendonner @bbondy @srirambv @LaurenWags @muliswilliam