Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Brave Ads save and dislike filters #20206

Closed
tmancey opened this issue Dec 22, 2021 · 1 comment · Fixed by brave/brave-core#11679
Closed

Fix Brave Ads save and dislike filters #20206

tmancey opened this issue Dec 22, 2021 · 1 comment · Fixed by brave/brave-core#11679
Assignees
@tmancey
Labels
bug feature/ads OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA/Yes release-notes/exclude
Milestone
1.35.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Dec 22, 2021 •
edited
Loading

Should be tested as part of #16005. Only affected 1.35 and above
@tmancey tmancey added bug priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude feature/ads OS/Desktop labels Dec 22, 2021
@tmancey tmancey self-assigned this Dec 22, 2021
@tmancey tmancey mentioned this issue Dec 22, 2021
Merged
25 tasks
@tmancey tmancey added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Dec 28, 2021
@tmancey tmancey added this to the 1.36.x - Nightly milestone Dec 29, 2021
@tmancey tmancey mentioned this issue Dec 29, 2021
Merged
4 tasks
@btlechowski btlechowski mentioned this issue Jan 12, 2022
Closed
@btlechowski
Copy link

btlechowski commented Jan 25, 2022 •
edited
Loading

Verification passed on

Brave 1.35.89 Chromium: 97.0.4692.71 (Official Build) beta (64-bit)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS Ubuntu 18.04 LTS

Save an ad

Confirmed ad was saved by clicking "Saved" filter
image

Confirm creative instance id was saved under client.json / adPreferences / saved_ads
image

Remove an ad from saved

Confirm ad was removed from "Saved" filter
image

Confirm creative instance id was removed from client.json / adPreferences / saved_ads
image

Mark as inappropriate (see kebab menu)

Confirm ads are blocked based upon the creative set id for the marked ad
image

[7965:7965:0120/204735.276974:VERBOSE2:exclusion_rules_base.cc(123)] creativeSetId 5e96fecc-2926-4c72-bb76-4e745bf6b539 excluded due to being marked as inappropriate

Confirm creative set id was saved under client.json / adPreferences / flagged_ads
image

Confirmation was successful

[7965:7965:0120/205112.689549:VERBOSE1:confirmations.cc(69)] Confirming flag for ad_notification with transaction id 8e8f13f7-0d8e-45ed-b388-702d09716831 and creative instance id 0e3fa44c-edd4-4ad3-b21e-e6c93ef001c4
[7965:7965:0120/205112.690913:VERBOSE1:redeem_unblinded_token.cc(55)] Redeem unblinded token
[7965:7965:0120/205112.691478:VERBOSE1:redeem_unblinded_token.cc(74)] CreateConfirmation
[7965:7965:0120/205112.691596:VERBOSE2:redeem_unblinded_token.cc(75)] POST /v2/confirmation/{confirmation_id}/{credential}
[7965:7965:0120/205112.691787:VERBOSE6:redeem_unblinded_token.cc(79)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v2/confirmation/a3cd30f3-36ac-4656-a6e4-1cd98186edef/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlbnNcIjpbXCJHRVIzamRUS016bE4rZ2ZBVjZ1N3VtR3hrVmV5K2p2NURwYk1hOXoxTEJBPVwiXSxcImJ1aWxkQ2hhbm5lbFwiOlwiYmV0YVwiLFwiY3JlYXRpdmVJbnN0YW5jZUlkXCI6XCIwZTNmYTQ0Yy1lZGQ0LTRhZDMtYjIxZS1lNmM5M2VmMDAxYzRcIixcInBheWxvYWRcIjp7fSxcInBsYXRmb3JtXCI6XCJsaW51eFwiLFwicHVibGljS2V5XCI6XCJpTWhSSGY5MnEyM05ueUpKTnBleVZ0S2JTaUNSRkxtS1g3UFE1bHJmaWs4PVwiLFwic3R1ZGllc1wiOltdLFwidHlwZVwiOlwiZmxhZ1wifSIsInNpZ25hdHVyZSI6IjNxamhaU29iMkNPN3FyOU9pWXVGRTgvNXZZL1JGVzlOdzFJbzFkL3o0M2Ivb2IzWk84NFhlT3k2V0VLeGVWbDU3azhtTmYzblp3RDBuemhFQmVPTWRRPT0iLCJ0IjoiaEMxLzNCckFMcENQYVJWMHlBQ1JTclBWbTl0TC84VUd1Y01RNmswQy9XNGM3UmgvVlhYQ1ZnaDJFMzdDVkFiL2o2SUNYb0ZQL0V0K3plQldPc0JzK3c9PSJ9
  Content: {"blindedPaymentTokens":["GER3jdTKMzlN+gfAV6u7umGxkVey+jv5DpbMa9z1LBA="],"buildChannel":"beta","creativeInstanceId":"0e3fa44c-edd4-4ad3-b21e-e6c93ef001c4","payload":{},"platform":"linux","publicKey":"iMhRHf92q23NnyJJNpeyVtKbSiCRFLmKX7PQ5lrfik8=","studies":[],"type":"flag"}
  Content Type: application/json
  Method: kPost
[7965:7965:0120/205112.920505:VERBOSE1:redeem_unblinded_token.cc(90)] OnCreateConfirmation
[7965:7965:0120/205112.920543:VERBOSE6:redeem_unblinded_token.cc(92)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v2/confirmation/a3cd30f3-36ac-4656-a6e4-1cd98186edef/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlbnNcIjpbXCJHRVIzamRUS016bE4rZ2ZBVjZ1N3VtR3hrVmV5K2p2NURwYk1hOXoxTEJBPVwiXSxcImJ1aWxkQ2hhbm5lbFwiOlwiYmV0YVwiLFwiY3JlYXRpdmVJbnN0YW5jZUlkXCI6XCIwZTNmYTQ0Yy1lZGQ0LTRhZDMtYjIxZS1lNmM5M2VmMDAxYzRcIixcInBheWxvYWRcIjp7fSxcInBsYXRmb3JtXCI6XCJsaW51eFwiLFwicHVibGljS2V5XCI6XCJpTWhSSGY5MnEyM05ueUpKTnBleVZ0S2JTaUNSRkxtS1g3UFE1bHJmaWs4PVwiLFwic3R1ZGllc1wiOltdLFwidHlwZVwiOlwiZmxhZ1wifSIsInNpZ25hdHVyZSI6IjNxamhaU29iMkNPN3FyOU9pWXVGRTgvNXZZL1JGVzlOdzFJbzFkL3o0M2Ivb2IzWk84NFhlT3k2V0VLeGVWbDU3azhtTmYzblp3RDBuemhFQmVPTWRRPT0iLCJ0IjoiaEMxLzNCckFMcENQYVJWMHlBQ1JTclBWbTl0TC84VUd1Y01RNmswQy9XNGM3UmgvVlhYQ1ZnaDJFMzdDVkFiL2o2SUNYb0ZQL0V0K3plQldPc0JzK3c9PSJ9
  Response Status Code: 201
  Response: {"id":"a3cd30f3-36ac-4656-a6e4-1cd98186edef","payload":{},"createdAt":"2022-01-20T18:50:20.813Z","type":"flag","modifiedAt":"2022-01-20T18:50:20.813Z","creativeInstanceId":"0e3fa44c-edd4-4ad3-b21e-e6c93ef001c4"}

Unmark as inappropriate (see kebab menu)

Confirm ads are not blocked based upon the creative set id for the unmarked ad
image

Confirmed ad was shown:

[8386:8386:0120/205949.906645:VERBOSE1:ad_notification_serving.cc(260)] Serving ad notification:
  uuid: 44ca577b-3116-4ab3-9f29-39d8210b71d1
  creativeInstanceId: 13fdf11c-b5f3-460a-b347-902862b65ef4
  creativeSetId: 5e96fecc-2926-4c72-bb76-4e745bf6b539
  campaignId: 0d01425b-c970-4a25-b2d0-ccf748cfaf6e
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: technology & computing
  title: Ad Set 2 - Creative 1 - Ad 1
  body: Ad Set 2 - Creative 1 - Ad 1
  targetUrl: https://youtube.com

Confirm creative set id was removed from client.json / adPreferences / flagged_ads
image

Mark to no longer receive (aka no entry icon)

Confirm ads are blocked based upon the category name for the marked ad
image

Confirm ad is blocked

[10528:10528:0125/021650.756151:VERBOSE2:exclusion_rules_base.cc(123)] creativeSetId c49b78ab-27a3-4a08-9cda-434f097d8cf8 excluded due to untargeted category being marked to no longer receive ads

Confirm category name was saved under client.json / adPreferences / filtered_categories

"filtered_categories":[{"name":"untargeted"}]

Unmark to no longer receive (aka heart icon or neutral, i.e. no icon selected)

Confirm ads are not blocked based upon the category name for the unmarked ad
image

Confirm category name was removed from client.json / adPreferences / filtered_categories

"filtered_categories":[]

Verified received the ad after unblocking

[14101:14101:0125/050243.397131:VERBOSE1:ad_notification_serving.cc(141)] Found 3 eligible ads
[14101:14101:0125/050243.397252:VERBOSE1:ad_notification_serving.cc(260)] Serving ad notification:
  uuid: 7620a0ab-d4d8-4b84-9a27-5edbe682728c
  creativeInstanceId: 4cda3ae7-1f70-4bca-b361-ca01d6a8f1ed
  creativeSetId: 5f8c4787-8431-49a5-9d09-bba40f8ad5f4
  campaignId: d1e25388-b362-4f30-bd4b-36b8205e59e5
  advertiserId: a34de75d-5654-4331-8713-8f4d4e2b6bf7
  segment: untargeted
  title: Vivamus sagittis lacus vel aug
  body: Duis mollis, est non commodo luctus, nisi erat porttitor lig
  targetUrl: https://www.apple.com

Dislike (aka thumbs down icon)

Confirm ads are blocked based upon the advertiser id for the disliked ad
image

Confirm advertiser id was saved under client.json / adPreferences / filtered_advertisers

{"filtered_advertisers":[{"id":"ecbcc833-8b1d-4867-98f7-ad2341396ce8"}]

Like (aka thumbs up icon or neutral, i.e. no icon selected)

Confirm ads are not blocked based upon the advertiser id for the liked ad

Ad was shown:

[3420:3420:0121/102112.968419:VERBOSE1:eligible_ad_notifications_v1.cc(39)] Get eligible ad notifications:
[3420:3420:0121/102112.969400:VERBOSE1:eligible_ad_notifications_v1.cc(150)] Get eligible ads for untargeted segment
[3420:3420:0121/102112.971101:VERBOSE1:seen_advertisers.h(30)] All ad_notification advertisers have been shown, so round robin
[3420:3420:0121/102112.971308:VERBOSE1:client.cc(446)] Resetting seen ad_notification advertisers
[3420:3420:0121/102112.971461:VERBOSE1:seen_ads.h(30)] All ad_notification ads have been shown, so round robin
[3420:3420:0121/102112.971549:VERBOSE1:client.cc(410)] Resetting seen ad_notifications
[3420:3420:0121/102112.971673:VERBOSE2:ad_priority.h(32)] 1 ads with a priority of 1 in bucket 1
[3420:3420:0121/102112.971891:VERBOSE1:ad_notification_serving.cc(141)] Found 1 eligible ads
[3420:3420:0121/102112.971982:VERBOSE1:ad_notification_serving.cc(260)] Serving ad notification:
  uuid: ac3e41b9-d76f-4d8d-8745-3fa62b2d0ce2
  creativeInstanceId: 4cda3ae7-1f70-4bca-b361-ca01d6a8f1ed
  creativeSetId: 5f8c4787-8431-49a5-9d09-bba40f8ad5f4
  campaignId: d1e25388-b362-4f30-bd4b-36b8205e59e5
  advertiserId: a34de75d-5654-4331-8713-8f4d4e2b6bf7
  segment: untargeted
  title: Vivamus sagittis lacus vel aug
  body: Duis mollis, est non commodo luctus, nisi erat porttito

Confirm advertiser id was removed from client.json / adPreferences / filtered_advertisers

"filtered_advertisers":[]

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
bug feature/ads OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.35.x - Release
Development

Successfully merging a pull request may close this issue.

Fix Brave Ads save and dislike filters brave/brave-core
3 participants
@tmancey @kjozwiak @btlechowski