Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent transaction confirmation if estimated gas limit is zero #20259

Closed
onyb opened this issue Dec 29, 2021 · 1 comment · Fixed by brave/brave-core#12044
Closed

Prevent transaction confirmation if estimated gas limit is zero #20259

onyb opened this issue Dec 29, 2021 · 1 comment · Fixed by brave/brave-core#12044
Assignees
@onyb
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA/No release-notes/include
Milestone
1.37.x - Release

Comments

@onyb
Copy link
Member

onyb commented Dec 29, 2021

If the gas limit is zero, we should disable the "Confirm" button with an error that indicates the user that there's something wrong with the gas estimation and they should manually specify a value.

⚠️ This is a safety mechanism to prevent issues with signing/broadcasting transactions. Since it can occur very rarely and cannot be reproduced easily, I've added the QA/No label.
@onyb onyb added QA/No release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Dec 29, 2021
@onyb onyb self-assigned this Jan 28, 2022
@onyb onyb mentioned this issue Jan 28, 2022
Merged
25 tasks
@onyb onyb added this to the 1.37.x - Nightly milestone Jan 31, 2022
@bbondy bbondy added this to Web3 Mar 18, 2022
@bbondy bbondy moved this to Done in Web3 Mar 18, 2022
@kjozwiak kjozwiak mentioned this issue Mar 30, 2022
Closed
@kyoobey
Copy link

kyoobey commented Apr 26, 2023

how can i opt out ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA/No release-notes/include
Projects
Web3
Archived in project
Milestone
1.37.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): show missing gas limit error in txn confirmation screen brave/brave-core
2 participants
@onyb @kyoobey