Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top Sites and Favorites are still clickable when not visible, with content scrolled up #20273

Closed
stephendonner opened this issue Dec 31, 2021 · 1 comment
Assignees
Labels
bug feature/brave-news formerly brave-today OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@stephendonner
Copy link

stephendonner commented Dec 31, 2021

Description

Top Sites and Favorites are still clickable when not visible, with content scrolled up

This is super minor, but a fun bug to find 👍

Steps to Reproduce

  1. new profile
  2. open a new-tab page
  3. enable Brave News
  4. scroll down
  5. scroll back up to just below where Top Sites / Favorites are (now hidden)
  6. move the mouse/pointer around and see that there are links

Actual result:

Although no longer visible, the Top Sites / Favorites are still clickable

opacity

Expected result:

If they're no longer visible, perhaps we shouldn't link them

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.34.76 Chromium: 97.0.4692.56 (Official Build) (x86_64)
Revision 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS macOS Version 11.6.1 (Build 20G224)
@mattmcalister mattmcalister added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 9, 2022
@mattmcalister
Copy link

Closing

@mattmcalister mattmcalister closed this as not planned Won't fix, can't repro, duplicate, stale May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/brave-news formerly brave-today OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
None yet
Development

No branches or pull requests

3 participants