-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global shield settings are not retained for Block scripts #2031
Comments
I think what happens here is that step 4 will add Nytimes into the allow list (can check it in chrome://settings/content/javascript), so we won't use the default shields rule but its own rule. |
@yrliou That's correct. I am seeing nytimes in Allow list under chrome://settings/content/javascript |
As per the above comment, it's expected behavior. Hence closing the issue. |
Description
Identified this issue while testing #1991
Before applying Global shield settings (Block script), if you have already enabled or disabled the shield site specific scripts, then the Global shield settings will not retained.
Steps to Reproduce
Actual result:
Global shield settings are not retained for Block scripts
Expected result:
Global shield settings should retain for all websites even after enabling or disabling the scripts.
Reproduces how often:
Always
Brave version (brave://version info)
Reproducible on current release:
Website problems only:
Additional Information
@kjozwiak @LaurenWags @srirambv @btlechowski
The text was updated successfully, but these errors were encountered: