Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to drag and reorder tabs on Linux #20386

Closed
iamjameswalters opened this issue Jan 7, 2022 · 68 comments
Closed

Unable to drag and reorder tabs on Linux #20386

iamjameswalters opened this issue Jan 7, 2022 · 68 comments
Labels
Chromium/reported upstream Issue has been reported upstream and crbug link is in the issue Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix closed/by-author feature/tabs-bar OS/Desktop OS/Linux priority/P3 The next thing for us to work on. It'll ride the trains. repros-on-chrome

Comments

@iamjameswalters
Copy link

Description

Attempting to drag tabs around to reorder them just pulls the tab out into its own window, which will not reduce and combine with any other windows.

Steps to Reproduce

  1. Open a series of tabs.
  2. Drag one of these tabs to a new spot in the tab dock.
  3. Or, try to drag a tab from one window into another window.

Actual result:

Tab is pulled out into its own window, and will not combine.

Expected result:

Tabs are reordered or tabs from separate windows are reduced to one window.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.34.80 Chromium: 97.0.4692.71 (Official Build) (64-bit)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS Linux (specifically, Ubuntu MATE 20.04.3)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes, I'm using the PPA
  • Can you reproduce this issue with the beta channel? Haven't tried
  • Can you reproduce this issue with the nightly channel? Haven't tried

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? Yes, installed the Chromium snap from the edge channel (at time of writing, version 98.0.4758.9) and this bug is present.

Miscellaneous Information:

Perhaps this is related to #20375 ? I encounter that bug as well.

@wildanpurnomo
Copy link

I experienced this issue as well after updating to 1.34.80 with AUR. I've downgraded back to 1.33.106 and tabs dragging went back to normal.

@bongochong
Copy link

bongochong commented Jan 8, 2022

Confirmed on this end too, under both Cinnamon and Xfce on Fedora 35.

Edit: If you right-click on unused space in the tab bar and un-check the Use system title bar and borders entry, this will allow tab reordering and dragging again, though you are sacrificing the standard title bar.

@Darshil-P
Copy link

Same issue here too.
With Brave Beta v1.35.75
On Debian Bookworm (KDE)

@SteshinSS
Copy link

Same issue with KDE Plasma 5.22.5 / Kubuntu 21.10

@otikscypi
Copy link

Duplicate: #20275. (but this one has more traction)

Also, yeah same here Gnome 40.5 / PopOS 21.10.

@jdnixx
Copy link

jdnixx commented Jan 8, 2022

Yep have this problem too. Comment on the reddit thread for 1.34.80: https://www.reddit.com/r/brave_browser/comments/rxp7zw/comment/hrl1m0j/

@jota2016
Copy link

jota2016 commented Jan 8, 2022

Same here.

Fedora 35 KDE.
Brave 1.34.80
Downgrading to 1.33.106 it works fine.

It's also happening with Chrome.
google-chrome-stable.x86_64 96.0.4664.110 --> works fine
google-chrome-stable.x86_64 97.0.4692.71 --> has the issue

The latest update of both browsers presents this behavior.

@ipha
Copy link

ipha commented Jan 8, 2022

This is broken upstream in chromium 97. There are patches available that have been applied to 98+, but not 97 yet

upstream bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1279532

patch 1/2: https://chromium-review.googlesource.com/c/chromium/src/+/3355376
patch 2/2: https://chromium-review.googlesource.com/c/chromium/src/+/3355470

@jota2016
Copy link

jota2016 commented Jan 8, 2022

Thanks for the info, @ipha

@iamjameswalters
Copy link
Author

Duplicate: #20275. (but this one has more traction)

Ack! Sorry 😅

@bsclifton bsclifton added Chromium/reported upstream Issue has been reported upstream and crbug link is in the issue Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix labels Jan 10, 2022
@bsclifton
Copy link
Member

bsclifton commented Jan 10, 2022

cc: @mariospr @mkarolin

+1 from users in #20275

Looks like the issue was fixed upstream; may be in our next Chromium update 👍 Thanks for linking the issues, @ipha 😄

@dusty-1
Copy link

dusty-1 commented Jan 13, 2022

For what it is worth, it appears that this issue is a general problem with "drag and drop", not just tabs. Here are some links to discussions of people impacted by "drag and drop" not working as it did in the previous version:

https://www.reddit.com/r/brave_browser/comments/s0tfp7/cant_claim_bat_because_captcha_doesnt_work/
https://community.brave.com/t/unable-to-drag-bookmarks-into-bookmarks-bar/316827
https://community.brave.com/t/after-clicking-on-brave-rewards-i-cannot-drag-bat-img-into-target-img-so-i-cannot-claim-bat-rewards/310719

@ipha
Copy link

ipha commented Jan 17, 2022

This is fixed upstream in Chromium 97.0.4692.92 and newer.

@neofutur
Copy link

neofutur commented Jan 17, 2022

serioulsly this is a HUGE functional bug that should be fixed ASAP. and since it is fixed upstream . . .

@nzbtuxnews
Copy link

Just to add -

I first saw this issue today with version 1.36.105 Chromium: 99.0.4844.45. It's working properly with brave-beta Version 1.37.72 Chromium: 99.0.4844.45 though.

Same here on Mint 20.3 running XFCE and Brave 1.36.116 Chromium: 99.0.4844.74 (Official Build) (64-bit)]

Cant drag tabs or reorder them, the entire desktop behaves like it has a seizure.

@khamer
Copy link

khamer commented Mar 29, 2022

Just adding - the AUR version of 1.36.122 Chromium 99.04844.88 shows this bug, but the Snap version does not.

@khamer
Copy link

khamer commented Apr 5, 2022

Beyond being broken in version 1.36.122 Chromium: 99.0.4844.88 (Official Build) (64-bit), After Brave Beta updated, it's also now broken in Brave Beta version 1.37.84 Chromium: 99.0.4844.51.

It works in the snap version of brave - 1.37.109 Chromium: 100.0.4896.60

I'm guessing there was a regression of this bug between 1.34.81 / 97.0.4692.99 and 1.36.105, but I'm worried there was another regression between 1.37.72 and 1.37.84.

@khamer
Copy link

khamer commented Apr 5, 2022

This is broken still even after updating in 1.37.109 Chromium: 100.0.4896.60 (using the AUR version not the snap.) Please reopen.

@error256
Copy link

error256 commented Apr 6, 2022

It works for me in 1.37.109 and 1.37.111 on the same system where it didn't at the time of the original issue, so some details must be different.

@khamer
Copy link

khamer commented Apr 6, 2022

Also doesn't work for me with 1.37.111 Chromium: 100.0.4896.79.

@khamer
Copy link

khamer commented Apr 6, 2022

Sorry for the frequent replies - testing out different versions available from the AUR, I found that the latest version of Brave is reporting

[194244:194244:0406/092550.112535:ERROR:wayland_window_drag_controller.cc(139)] zcr_extended_drag_v1 extension not available! Window/Tab dragging won't be fully functional.

Which lead me to Sway #5692 and wlroots #2889. These issues are both closed and Chromium is supposed to be patched for around a year.

Sure enough, I have the follow brave-flags enabled:

--enable-features=UseOzonePlatform
--ozone-platform=wayland

And if I remove those, dragging works again, but that causes other issues (with things like screensharing.)

So my guess is that this may be a different issue than the original, and now Brave doesn't work properly under Wayland anymore.

@loyd
Copy link

loyd commented May 26, 2022

It's broken for me on v1.39.111/102.0.5005 from AUR. Xorg =(

@nPHYN1T3
Copy link

Why is this marked as closed? Still an issue on V1.39.111 (May 24, 2022) (also X here)

@error256
Copy link

It broke after the latest update. Now it's broken in some weird way: most of the time it doesn't work, but sometimes tabs can be dragged correctly. When they can, it works correctly for all the tabs in the window until I switch to another window, then it can stop working in that window too.

@nPHYN1T3
Copy link

It's been broken to some degree for several updates. I noticed a while ago tab tearing was virtually impossible but I could move a tab in a window, now you can't do either. Just an ongoing regression that is now pushing 5 months.

@khamer
Copy link

khamer commented May 31, 2022

In case it helps, I'm on Manjaro, Brave Browser 102.1.39.111, with the following in ~/.config/brave-flags.conf

--enable-features=UseOzonePlatform --ozone-platform=wayland --ignore-gpu-blocklist --enable-gpu-rasterization --enable-zero-copy

And it works for me these days but used to be broken. Some of these flags I believe are related to wayland/screensharing on wayland, but wanted to include these in case any of these matter.

@nPHYN1T3
Copy link

nPHYN1T3 commented May 31, 2022

Wayland flags only help if you run Wayland which is also to say this isn't a Wayland issue.

@mil-ad
Copy link

mil-ad commented Jun 2, 2022

@bbondy I still have this issue on Brave 1.39.111 (Chromium: 102.0.5005.61). Is there a new issue to track this?

@nPHYN1T3
Copy link

nPHYN1T3 commented Jun 2, 2022

Exactly why the hell is this closed?! I know a lot of these issues aren't Braves fault per-say but it seems like the Google whims of enabling, disabling, killing and breaking see everything based on Chromium on a roller coaster of regressions and pointless changes.

@bbondy
Copy link
Member

bbondy commented Jun 2, 2022

I believe this is a known upstream issue in Chromium and they will have it in the next Chromium bump. It was probably closed when the issue previously happened and was fixed, but then re-introduced again. cc @mkarolin for better info than I have.

@ristomatti
Copy link

ristomatti commented Jun 3, 2022

I've ended up here by searching for such issue on Chromium. If anyone reading happens to know a link to watch, it would be most welcome! This definitely appeared on Chromium 102.

Edit: This is likely it: https://bugs.chromium.org/p/chromium/issues/detail?id=1279532. The issue also seems to be fixed on Chromium Beta (103).

@mkarolin
Copy link
Contributor

mkarolin commented Jun 9, 2022

Please, recheck with the latest 1.39.120 release. This release includes the Chromium fix.

@nPHYN1T3
Copy link

nPHYN1T3 commented Jun 9, 2022

I'm on 1.39.120, no change.

@mil-ad
Copy link

mil-ad commented Jun 9, 2022

1.39.120 does fix the problem for me!

@nPHYN1T3
Copy link

nPHYN1T3 commented Jun 9, 2022

Fix which, moving tabs or tearing/replacing? I can reorder now on [Version 1.39.120 Chromium: 102.0.5005.99 (Official Build) but that's only half the issue.

@mil-ad
Copy link

mil-ad commented Jun 9, 2022

Moving tabs. This issue doesn't seem to be related to tearing?

@nPHYN1T3
Copy link

nPHYN1T3 commented Jun 9, 2022

Moving, tearing and replacing are all the same thing as far as the action of moving tabs to and from an ordered position or specific window. However I just tried again and I CAN get a tab to re-attach but it's still really jank. So it's fixed...but it sucks. It's not as bad a Vivaldi but it's pretty crap. Basically if I try to move a tab to a window it does nothing (same as before) however if I drag the tab ABOVE the window and back down then it reattaches.

@mil-ad
Copy link

mil-ad commented Jun 9, 2022

what window manager are you using? If you're on i3 then you might want to try something like Syphdias/i3-chrome-tab-dragging

@nPHYN1T3
Copy link

nPHYN1T3 commented Jun 9, 2022

CTWM - It's not my WM, for example tor I can tear, reorder and reattach just fine. As was I able to a few versions back of Brave.

Off topic but interesting how you would think I was on i3. Kinda interesting to see lots of talk or people moving to tiling wm these days. I run CTWM because all the "big boys" are GTK bound which is completely broken since v3 for multi GPU. KDE being the odd one out for big and not GTK just has some horrible behaviors for my set up, not to mention bloated and I hate the K ecosystem. QT is a nightmare. end rant.

@wommy
Copy link

wommy commented Jun 11, 2022

@mil-ad
what window manager are you using? If you're on i3 then you might want to try something like Syphdias/i3-chrome-tab-dragging

Syphdias/i3-chrome-tab-dragging#5

@ristomatti
Copy link

Seems to have been fixed on Chrome 102.0.5005.115 (Linux Mint 20).

Curiously it was not yet fixed on Chromium 102.0.5005.61 or Edge 102.0.1245.39 which both were upgraded as well.

@diivi
Copy link

diivi commented Aug 27, 2023

I still get this problem on v1.57.53, Ubuntu

@kilroyjones
Copy link

I am also experience odd window dragging issues, though the window will actually float to the bottom of the screen and then disappear, but only on my second monitor. I am using Linux Mint - KDE Plasma with Brave version 1.60.118 and Chromium: 119.0.6045.163.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chromium/reported upstream Issue has been reported upstream and crbug link is in the issue Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix closed/by-author feature/tabs-bar OS/Desktop OS/Linux priority/P3 The next thing for us to work on. It'll ride the trains. repros-on-chrome
Projects
None yet
Development

No branches or pull requests