Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only handle torrent URLs when WebTorrent extension is enabled #2043

Closed
yrliou opened this issue Nov 8, 2018 · 2 comments · Fixed by brave/brave-core#832
Closed

Only handle torrent URLs when WebTorrent extension is enabled #2043

yrliou opened this issue Nov 8, 2018 · 2 comments · Fixed by brave/brave-core#832

Comments

@yrliou
Copy link
Member

yrliou commented Nov 8, 2018

We should only handle torrent URLs when WebTorrent extension is enabled as we currently does for magnet URLs.

@btlechowski
Copy link

btlechowski commented Dec 12, 2018

Verification passed on

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows 7 x64

Used STR from brave/brave-core#832

Verification PASSED on Ubuntu 18.04 x64 using the following build:

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Linux

Verification PASSED on macOS 10.14 x64 using the following build:

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Mac OS X

@kjozwiak
Copy link
Member

kjozwiak commented Dec 12, 2018

@yrliou noticed that when using Open link in private window with Tor, we're still prompting users to open the .torrent files with whatever third party application is associated with .torrent files. I know we basically blocked everything re: .torrent when we were on muon.

Do we know if there's any privacy concerns in allowing .torrent files to be downloaded from a none-Tor Window to a Tor Window?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment