Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different wording for "Log out from {custodian name}" when user is in Logged Out state #20451

Closed
Miyayes opened this issue Jan 11, 2022 · 2 comments · Fixed by brave/brave-core#11854
Assignees
Labels
feature/rewards needs-text-change This change requires some careful wording. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/exclude rewards-2.0

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Jan 11, 2022

Description

State is called "Logged out", however an option to "Log out from {custodian}" also appears, which could be a little confusing.

image

Solution

Use "Disconnect from {custodian}" language in this case.

@Miyayes Miyayes added needs-text-change This change requires some careful wording. feature/rewards OS/Desktop rewards-2.0 labels Jan 11, 2022
@Miyayes Miyayes added the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Jan 11, 2022
@Miyayes
Copy link
Collaborator Author

Miyayes commented Jan 12, 2022

Change to "Disconnect from {custodian}"

@zenparsing zenparsing added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 12, 2022
@Miyayes Miyayes added QA/Yes and removed needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. labels Jan 13, 2022
@emerick emerick self-assigned this Jan 14, 2022
@emerick emerick added this to the 1.36.x - Nightly milestone Jan 18, 2022
@stephendonner
Copy link

stephendonner commented Jan 19, 2022

Verified PASSED using

Brave 1.36.47 Chromium: 97.0.4692.71 (Official Build) nightly (x86_64)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS macOS Version 11.6.1 (Build 20G224)

Steps (for each custodian):

  1. new profile
  2. launched Brave using --enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=3
  3. loaded brave://rewards
  4. clicked on Start using Rewards
  5. clicked on Verify Wallet
  6. entered test credentials
  7. returned to brave://rewards / clicked on the BAT icon
  8. clicked on the My Wallet dropdown
  9. examined the text
bitFlyer, Verified bitFlyer, logged out Uphold, Verified Uphold, logged out Gemini, Verified Gemini, logged out
Screen Shot 2022-01-19 at 18 45 39 Screen Shot 2022-01-19 at 19 58 39 Screen Shot 2022-01-19 at 2 02 00 PM Screen Shot 2022-01-19 at 14 06 47 Screen Shot 2022-01-19 at 2 32 23 PM Screen Shot 2022-01-19 at 8 09 38 PM

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards needs-text-change This change requires some careful wording. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/exclude rewards-2.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants