Nightly on Android does not turn off Rewards icon

[pratyakshm]

Description

Steps to reproduce

1. Go to Brave Nightly Settings > Appearance.
2. Turn Show Brave Rewards icon in address bar* off.
3. It prompts to restart app for changes to take effect, hence tap on Relaunch now.

Actual result

Brave Rewards icon is not disabled from the toolbar.

Expected result

Brave Rewards icon is disabled.

Issue reproduces how often

Easily reproduced

Version/Channel Information:

• Can you reproduce this issue with the current Play Store version? No
• Can you reproduce this issue with the current Play Store Beta version? No response
• Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

• Install type (ARM, x86): ARM64
• Device type (Phone, Tablet, Phablet): Phablet
• Android version: 11

Brave version

1.36.58

Website problems only

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Additional information

[Miyayes]

I wonder if recent change #19695 for this setting on desktop is not propagating nicely over into Android? cc: @emerick

[emerick]

Yes, I think we'll need to do a real preference migration on Android. @deeppandya I may ping you for some pointers...

[Uni-verse]

I am still able to repro this issue on 1.36.96, chromium 98.0.4758.87 - https://github.com/brave/brave-browser/releases/tag/v1.36.96

After the browser relaunches, changes do not take affect.

[kjozwiak]

Adding QA/Blocked for Android till #21183 is addressed/fixed. The above can also be tested alongside #19695 & #20646 when #21183 is fixed.

[srirambv]

Verification passed as part of #21183 (comment).

• Verified on both clean install and upgrade scenario rewards button is hidden or shown based on the setting