-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce "You've set up a pending tip" messaging for pending tip cases #20748
Comments
Text: "You've set up a pending tip!" |
Verified with
Note, manually enabled "Use WebUI Rewards Panel" prior to below cases to do additional testing of #22423. Anon wallet (vBAT funded) - PASSEDConfirmed correct messaging on panel for unverified creator.
Confirmed connected (not KYC'd), Uphold, Gemini, bitFlyer creators all showed as "Verified Creator" with no hover text on the panel.
Uphold wallet - PASSEDConfirmed correct messaging on panel for unverified creator.
Confirmed Uphold creator showed as "Verified Creator" with no hover text on the panel.
bitFlyer wallet - PASSEDConfirmed correct messaging on panel for unverified creator.
Confirmed bitFlyer creator showed as "Verified Creator" with no hover text on the panel.
Gemini wallet - PASSEDConfirmed correct messaging on panel for unverified creator.
Confirmed Gemini creator showed as "Verified Creator" with no hover text on the panel.
|
Description
When a tip cannot go through and goes into the pending state, we should change the success messaging (right side of the tipping banner on desktop) to something that actually reflects the fact that the tip went into pending. The current text, which says "Your one-time tip has been sent" makes it seem as though the tip succeeded at that point.
Example:
The text was updated successfully, but these errors were encountered: