Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce "You've set up a pending tip" messaging for pending tip cases #20748

Closed
Miyayes opened this issue Jan 27, 2022 · 3 comments · Fixed by brave/brave-core#14263
Closed
Assignees
Labels
feature/rewards needs-text-change This change requires some careful wording. OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Yes release-notes/include

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Jan 27, 2022

Description

When a tip cannot go through and goes into the pending state, we should change the success messaging (right side of the tipping banner on desktop) to something that actually reflects the fact that the tip went into pending. The current text, which says "Your one-time tip has been sent" makes it seem as though the tip succeeded at that point.

Example:

image

@Miyayes Miyayes added needs-text-change This change requires some careful wording. feature/rewards OS/Desktop labels Jan 27, 2022
@Miyayes Miyayes added the QA/Yes label Jan 28, 2022
@zenparsing zenparsing added the priority/P4 Planned work. We expect to get to it "soon". label Feb 2, 2022
@Miyayes Miyayes assigned Miyayes and mkarolin and unassigned Miyayes Jul 16, 2022
@Miyayes
Copy link
Collaborator Author

Miyayes commented Jul 20, 2022

Text: "You've set up a pending tip!"

@LaurenWags
Copy link
Member

LaurenWags commented Aug 9, 2022

Verified with

Brave | 1.43.63 Chromium: 104.0.5112.81 (Official Build) beta (x86_64)
-- | --
Revision | 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS | macOS Version 12.5 (Build 21G72)

Note, manually enabled "Use WebUI Rewards Panel" prior to below cases to do additional testing of #22423.

flag
Anon wallet (vBAT funded) - PASSED

Confirmed correct messaging on panel for unverified creator.
Confirmed setting up a pending tip showed expected message on tip banner for unverified creator.
Confirmed tip displayed in Pending Contributions list.

Example Example Example
1 2 3

Confirmed connected (not KYC'd), Uphold, Gemini, bitFlyer creators all showed as "Verified Creator" with no hover text on the panel.
Confirmed able to tip connected (not KYC'd) creator.
Confirmed able to tip Uphold KYC'd creator.
Confirmed able to tip Gemini KYC'd creator.
Confirmed able to tip bitFlyer KYC'd creator.
Confirmed no "pending" tip messaging for any of the above creators.
Confirmed all tips displayed in "Tips" panel.
Confirmed all tips deducted from balance as expected.

Connected Uphold Gemini bitFlyer Tips panel Wallet panel
1 2 3 4 5 6
Uphold wallet - PASSED

Confirmed correct messaging on panel for unverified creator.
Confirmed setting up a pending tip for unverified creator showed expected message on tip banner.
Confirmed connected (not KYC'd), Gemini, bitFlyer creators all showed as "Verified Creator" with hover text on the panel.
Confirmed setting up a pending tip for connected (not KYC'd) creator showed expected message on tip banner.
Confirmed setting up a pending tip for Gemini creator showed expected message on tip banner.
Confirmed setting up a pending tip for bitFlyer creator showed expected message on tip banner.
Confirmed tips displayed in Pending Contributions list.

. Panel Tip Banner Pending Contributions list
Unverified 1 2 3
Connected (not KYC'd) 4 5 6
Gemini 1 2 3
bitFlyer 4 5 6

Confirmed Uphold creator showed as "Verified Creator" with no hover text on the panel.
Confirmed able to tip Uphold KYC'd creator.
Confirmed no "pending" tip messaging on tip banner.
Confirmed tip displayed in "Tips" panel.
Confirmed tip deducted from balance as expected.

Panel Tip Banner Tips panel Wallet panel
1 2 3 4
bitFlyer wallet - PASSED

Confirmed correct messaging on panel for unverified creator.
Confirmed setting up a pending tip for unverified creator showed expected message on tip banner.
Confirmed connected (not KYC'd), Uphold, Gemini creators all showed as "Verified Creator" with hover text on the panel.
Confirmed setting up a pending tip for connected (not KYC'd) creator showed expected message on tip banner.
Confirmed setting up a pending tip for Uphold creator showed expected message on tip banner.
Confirmed setting up a pending tip for Gemini creator showed expected message on tip banner.
Confirmed tips displayed in Pending Contributions list.

. Panel Tip Banner Pending Contributions list
Unverified 1 2 3
Connected (not KYC'd) 4 5 6
Uphold 1 2 3
Gemini 4 5 6

Confirmed bitFlyer creator showed as "Verified Creator" with no hover text on the panel.
Confirmed able to tip bitFlyer KYC'd creator.
Confirmed no "pending" tip messaging on tip banner.
Confirmed tip displayed in "Tips" panel.
Confirmed tip deducted from balance as expected.

Panel Tip Banner Tips panel Wallet panel
1 2 3 4
Gemini wallet - PASSED

Confirmed correct messaging on panel for unverified creator.
Confirmed setting up a pending tip for unverified creator showed expected message on tip banner.
Confirmed connected (not KYC'd), Uphold, bitFlyer creators all showed as "Verified Creator" with hover text on the panel.
Confirmed setting up a pending tip for connected (not KYC'd) creator showed expected message on tip banner.
Confirmed setting up a pending tip for Uphold creator showed expected message on tip banner.
Confirmed setting up a pending tip for bitFlyer creator showed expected message on tip banner.
Confirmed tips displayed in Pending Contributions list.

. Panel Tip Banner Pending Contributions list
Unverified 1 2 3
Connected (not KYC'd) 4 5 6
Uphold 1 2 3
bitFlyer 4 5 6

Confirmed Gemini creator showed as "Verified Creator" with no hover text on the panel.
Confirmed able to tip Gemini KYC'd creator.
Confirmed no "pending" tip messaging on tip banner.
Confirmed tip displayed in "Tips" panel.
Confirmed tip deducted from balance as expected.

Panel Tip Banner Tips panel Wallet panel
1 2 3 4

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 23, 2022

Verification PASSED on


Brave | 1.43.78 Chromium: 104.0.5112.102 (Official Build) beta (64-bit)
-- | --
Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS | Windows 10 Version 21H2 (Build 19044.1889)
Anon wallet (vBAT funded) -PASSED

Confirmed correct messaging on panel for unverified creator.
Confirmed setting up a pending tip showed expected message on tip banner for unverified creator.
Confirmed tip displayed in Pending Contributions list.

Example Example Example Example
image image image image

Confirmed connected (not KYC'd), Uphold, Gemini, bitFlyer creators all showed as "Verified Creator" with no hover text on the panel.
Confirmed able to tip connected (not KYC'd) creator.
Confirmed able to tip Uphold KYC'd creator.
Confirmed able to tip Gemini KYC'd creator.
Confirmed able to tip bitFlyer KYC'd creator.
Confirmed no "pending" tip messaging for any of the above creators.
Confirmed all tips displayed in "Tips" panel.
Confirmed all tips deducted from balance as expected.

Connected Uphold Gemini bitFlyer Tips panel Wallet panel
image image image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards needs-text-change This change requires some careful wording. OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants