DCHECK failed: g_key_creation_util

[darkdh]

#2013 (comment)

[1840:15363:1109/095139.569243:FATAL:os_crypt_mac.mm(103)] Check failed: g_key_creation_util.
0   libbase.dylib                       0x0000000108dd65ee base::debug::StackTrace::StackTrace(unsigned long) + 174
1   libbase.dylib                       0x0000000108dd66ad base::debug::StackTrace::StackTrace(unsigned long) + 29
2   libbase.dylib                       0x00000001089a7d2a base::debug::StackTrace::StackTrace() + 26
3   libbase.dylib                       0x0000000108a15dad logging::LogMessage::~LogMessage() + 461
4   libbase.dylib                       0x0000000108a13945 logging::LogMessage::~LogMessage() + 21
5   libos_crypt.dylib                   0x0000000115ff6744 (anonymous namespace)::GetEncryptionKey() + 2340
6   libos_crypt.dylib                   0x0000000115ff9bc1 OSCrypt::DecryptString(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*) + 3105

Test Plan

1. Save some passwords in a Muon profile.
   • They will be encrypted with the "Chromium Safe Storage" keychain key and stored in the login database.
2. To simulate first run, ensure there is not already a brave-core user data directory.
3. Run brave-core with --upgrade-from-muon.
   • I used /path/to/brave/src/out/Debug/Brave\ Browser\ Development.app/Contents/MacOS/Brave\ Browser\ Development --enable-logging --v=0 --disable-brave-update --upgrade-from-muon.
4. When prompted, Allow keychain access for "Chromium Safe Storage" and "Brave Safe Storage."
5. In brave-core, verify that the saved passwords from Muon are available and can be used to login successfully.

[LaurenWags]

Verified passed with `macOS 10.12.6 x64' using

Brave	0.57.7 Chromium: 71.0.3578.53 (Official Build) beta(64-bit)
Revision	599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS	Mac OS X

• Verified test plan from description. cc @kjozwiak for a second check on his mac.

Went through verification using the following build under macOS 10.14 x64 - PASSED

Brave	0.57.12 Chromium: 71.0.3578.75 (Official Build) (64-bit)
Revision	06ef00b5279f93f8e0c1e73acedd49d7dcc09767-refs/branch-heads/3578@{#836}
OS	Mac OS X