Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible race condition when starting IPFS node #20845

Closed
mcamou opened this issue Feb 2, 2022 · 2 comments
Closed

Possible race condition when starting IPFS node #20845

mcamou opened this issue Feb 2, 2022 · 2 comments

Comments

@mcamou
Copy link

mcamou commented Feb 2, 2022

Description

The first time that you click on "Open Using IPFS" you get an error, "Can't load IPFS resources using local node". If you reload the page it works. It looks like a race condition: Brave is not waiting for the IPFS node to finish initializing before trying to load the content.

Steps to Reproduce

  1. Open a fresh instance of Brave
  2. Go to a page that is backed on IPFS (e.g. https://protocol.ai)
  3. Click on "Open Using IPFS"

Actual result:

An error page stating "Can't read IPFS resources using local node". If you reload the page it works.

Expected result:

The page should show up the first time.

Reproduces how often:

Always.

Brave version (brave://version info)

Brave 1.34.81 Chromium: 97.0.4692.99 (Official Build) (64-bit)
Revision d740da257583289dbebd2eb37e8668928fac5ead-refs/branch-heads/4692@{#1461}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Have not tried it
  • Can you reproduce this issue with the nightly channel? Have not tried it

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? No, since Chrome does not have native IPFS support

Miscellaneous Information:

This might have to do with the size of the IPFS block store (since startup time will depend on the size).

$ ipfs --api /ip4/127.0.0.1/tcp/45005 repo stat
NumObjects: 345
RepoSize:   17103248
StorageMax: 1000000000
RepoPath:   /home/mario/.config/BraveSoftware/Brave-Browser/brave_ipfs
Version:    fs-repo@11
@mcamou mcamou changed the title Race condition when starting IPFS node Possible race condition when starting IPFS node Feb 2, 2022
@spylogsster
Copy link

Hi @mcamou,
This seems fixed in Nightly, can you please check if possible and let us know if still reproduced, thanks

@vadimstruts
Copy link
Collaborator

The IPFS local node and scheme has been deprecated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants