Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom EVM is removed when trying to edit chain ID #20967

Closed
srirambv opened this issue Feb 8, 2022 · 1 comment · Fixed by brave/brave-core#12204
Closed

Custom EVM is removed when trying to edit chain ID #20967

srirambv opened this issue Feb 8, 2022 · 1 comment · Fixed by brave/brave-core#12204
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

srirambv commented Feb 8, 2022

Description

Custom EVM is removed when trying to edit it

Steps to reproduce

  1. Reset wallet if you already have (if not ignore this step)
  2. Add a custom network via settings
  3. Create a new wallet, ensure the custom EVM network is shown in dropdown
  4. Switch to the custom network
  5. Open wallet settings via menu from wallet page
  6. Select the custom network added
  7. Edit the network (should not be able to edit as its current active network)
  8. Close the network edit window, portfolio doesn't show custom network but shows mainnet
  9. Go to Menu-> Settings-> Wallet -> Networks, no custom EVM is available that was added in step 2

Actual result

https://bravesoftware.slack.com/archives/C023VS4HJ6Q/p1644304626329969

Expected result

Should not allow to edit an active network and should not be removed just because you edit it

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): All
  • Android version: All

Brave version

1.36.87

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @SergeyZhukovsky

@srirambv
Copy link
Contributor Author

Verification passed on the following devices running 1.336.99 x64 beta build

  • Verified when Buy & Swap screens are opened, custom networks are not listed
  • Encountered #21047
Oppo Reno 5 (Android 12) Samsung Tab A (Android 10)
20967-ARM.mp4
20967-Tab.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants