Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that only one URL can be used in network settings #20968

Closed
srirambv opened this issue Feb 8, 2022 · 3 comments · Fixed by brave/brave-core#12204
Closed

Clarify that only one URL can be used in network settings #20968

srirambv opened this issue Feb 8, 2022 · 3 comments · Fixed by brave/brave-core#12204
Assignees
@SergeyZhukovsky
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Milestone
1.36.x - Release

Comments

@srirambv
Copy link
Contributor

srirambv commented Feb 8, 2022

Description

No option to add multiple RPC url's

Steps to reproduce

  1. Install 1.36.87 beta build
  2. Add a custom network
  3. Only able to add one RPC Url

Actual result

Expected result

Similar to desktop
image

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): All
  • Android version: All

Brave version

1.36.87 beta build

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @SergeyZhukovsky
@srirambv srirambv added QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Feb 8, 2022
@srirambv srirambv mentioned this issue Feb 8, 2022
Closed
@SergeyZhukovsky
Copy link
Member

@srirambv it's all following a spec form from desktop to be created on mobile, notice that urls can be a list of urls on mobile we will only support a single url for each.

@SergeyZhukovsky
Copy link
Member

I'm going just replace URLs to URL as it looks confusing.

@SergeyZhukovsky SergeyZhukovsky self-assigned this Feb 9, 2022
@SergeyZhukovsky SergeyZhukovsky mentioned this issue Feb 10, 2022
Merged
25 tasks
@brave-builds brave-builds mentioned this issue Feb 10, 2022
Merged
7 tasks
@SergeyZhukovsky SergeyZhukovsky added this to the 1.37.x - Nightly milestone Feb 10, 2022
@srirambv
Copy link
Contributor Author

Verification passed on the following devices running 1.36.99 x64 beta build

  • Verified URL's is replaced with URL
Oppo Reno 5 (Android 12) Samsung Tab A (Android 10)
20968.-.ARM.mp4
20968.-.Tab.mp4

@bbondy bbondy changed the title No option to add multiple RPC url's Clarify that only one URL can be used in network selection Mar 1, 2022
@bbondy bbondy changed the title Clarify that only one URL can be used in network selection Clarify that only one URL can be used in network settings Mar 1, 2022
@bbondy bbondy added this to Web3 Mar 18, 2022
@bbondy bbondy moved this to Done in Web3 Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SergeyZhukovsky SergeyZhukovsky

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.36.x - Release
Development

Successfully merging a pull request may close this issue.

Various fixes for Android EVM networks feature brave/brave-core
3 participants
@kjozwiak @SergeyZhukovsky @srirambv