Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser crash when selecting 'Send to your devices' #21035

Closed
anshumanpati6 opened this issue Feb 11, 2022 · 7 comments · Fixed by brave/brave-core#12232
Closed

Browser crash when selecting 'Send to your devices' #21035

anshumanpati6 opened this issue Feb 11, 2022 · 7 comments · Fixed by brave/brave-core#12232
Assignees
Labels
crash needs-more-info The report requires more detail before we can decide what to do with this issue. OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Device-Types QA/Yes release-notes/include

Comments

@anshumanpati6
Copy link

Description

Brave crashes when clicking on send to device in Android.

Steps to reproduce

  1. Open the menu
  2. Click on share
  3. Select 'send to your devices'

Actual result

Browser crashes.

Expected result

Should show list of other devices to send the tab to.

Issue reproduces how often

Easily reproduced.

Version/Channel Information:

Brave Android Stable Channel 1.35.100

  • Can you reproduce this issue with the current Play Store version?
  • Yes

Device details

  • Install type (ARM, x86): ARM64
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 12

Brave version

1.35.100

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • No
  • Does the issue resolve itself when disabling Brave Rewards?
  • No
  • Is the issue reproducible on the latest version of Chrome?
  • No
@anshumanpati6 anshumanpati6 added the OS/Android Fixes related to Android browser functionality label Feb 11, 2022
@srirambv
Copy link
Contributor

Can you submit the crash report via brave://crashesand share the crash ID here? Make sure you enable the send crash reports in settings

cc: @SergeyZhukovsky

@srirambv srirambv added crash needs-more-info The report requires more detail before we can decide what to do with this issue. labels Feb 11, 2022
@anshumanpati6
Copy link
Author

Crash ID - 028b0100-251c-ba07-0000-000000000000

@srirambv
Copy link
Contributor

srirambv commented Feb 16, 2022

Verification passed on Samsung Tab A with Android 10 running 1.35.102 x64 build

  • Verified enabling Sync everything shows the device when Send to devices is selected
  • Verified able to send the open tab to other device in sync chain
  • Verified other devices in sync chain receive the open tabs that are sent via Sync
  • Verified no crash on either devices in Sync chain when an open tab is sent
  • Verified no crash on sending device when the receiving device is offline
Sending Device Receiving Device

@Uni-verse
Copy link
Contributor

Uni-verse commented Feb 16, 2022

Verification completed using Brave 1.35.102, Chromium 98.0.4758.102

PASSED on Samsung Galaxy S21 / Android 12

  • Verified no crash occurs when user selects and opens 'Send to Devices' share option
  • Verified synced devices show up in 'Send to Devices'
  • Verified selected devices successfully receive the open tab link
  • Verified no crash on sending device when the receiving device is offline
Tx Rx brave://version
Screenshot_20220217-043642_Brave Screen Shot 2022-02-16 at 1 37 51 PM Screenshot_20220217-044211_Brave

@marc0der
Copy link

marc0der commented Apr 6, 2022

Hi @srirambv! This issue seems to be back in 1.37.110. The browser crashes consistently every time I send to my devices from my Google Pixel 5, Android 12. Please shout if I can do anything to help reproduce the issue.

@steveharman
Copy link

Hi @srirambv! This issue seems to be back in 1.37.110. The browser crashes consistently every time I send to my devices from my Google Pixel 5, Android 12. Please shout if I can do anything to help reproduce the issue.

Same issue is back for me too, same version (Android)

@samartnik
Copy link
Contributor

New issue was created for this one #22128
Should be fixed in version 1.37.113 of higher.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash needs-more-info The report requires more detail before we can decide what to do with this issue. OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Device-Types QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants