Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave sync be ready to receive bookmark before folder #2104

Closed
AlexeyBarabash opened this issue Nov 12, 2018 · 2 comments
Closed

Brave sync be ready to receive bookmark before folder #2104

AlexeyBarabash opened this issue Nov 12, 2018 · 2 comments
Assignees
@AlexeyBarabash
Labels
closed/duplicate Issue has already been reported closed/invalid feature/sync priority/P2 A bad problem. We might uplift this to the next planned release.

Comments

@AlexeyBarabash
Copy link
Contributor

Description

Android team and iOS team mentioned it is possible to receive bookmark created sync record before parent bookmark folder created record. In this case in brave-core the bookmark will remain orphaned. Never see this situation with brave-core.

Steps to Reproduce

No steps to reproduce it for sure.
May be emulated with auto-test.

Actual result:

The bookmark remains orphaned. Folder is created after and remains empty.

Expected result:

After arriving folder created record, child bookmark should be moved into. Or if folder and bookmark arrived in the same list, list should be sorted by time, as Android browser does.

Reproduces how often:

No steps to reproduce

Brave version (brave://version info)

Brave | 0.56.12 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision | 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
@bbondy bbondy added this to the 1.x Backlog milestone Nov 13, 2018
@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. release/blocking labels Nov 16, 2018
@AlexeyBarabash AlexeyBarabash mentioned this issue Nov 26, 2018
Closed
@AlexeyBarabash
Copy link
Contributor Author

This is a duplicate of #2133 .

@darkdh
Copy link
Member

darkdh commented Dec 5, 2018

close this issue because we need QA verifying #2133

@darkdh darkdh closed this as completed Dec 5, 2018
@darkdh darkdh modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Dec 5, 2018
@darkdh darkdh added closed/duplicate Issue has already been reported and removed release/blocking labels Dec 5, 2018
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexeyBarabash AlexeyBarabash

Labels
closed/duplicate Issue has already been reported closed/invalid feature/sync priority/P2 A bad problem. We might uplift this to the next planned release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bbondy @rebron @darkdh @AlexeyBarabash