Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tooltip to Disabled Send Button State #21053

Closed
Douglashdaniel opened this issue Feb 11, 2022 · 1 comment · Fixed by brave/brave-core#12327
Closed

Add Tooltip to Disabled Send Button State #21053

Douglashdaniel opened this issue Feb 11, 2022 · 1 comment · Fixed by brave/brave-core#12327
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/include
Milestone
1.37.x - Release

Comments

@Douglashdaniel
Copy link

Description

We need to add a Tooltip to the Send button when it is disabled, to explain why it is disabled.
example: Amount must be greater than 0

Screen Shot 2022-02-10 at 2 26 23 PM
@Douglashdaniel Douglashdaniel added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Feb 11, 2022
@Douglashdaniel Douglashdaniel self-assigned this Feb 11, 2022
@Douglashdaniel Douglashdaniel mentioned this issue Feb 18, 2022
Merged
24 tasks
@Douglashdaniel Douglashdaniel added this to the 1.37.x - Nightly milestone Feb 23, 2022
@bbondy bbondy added this to Web3 Mar 18, 2022
@bbondy bbondy moved this to Done in Web3 Mar 18, 2022
@Uni-verse
Copy link
Contributor

Verification Completed using

Brave	1.37.105 Chromium: 100.0.4896.46 (Official Build) (x86_64) 
Revision	5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS	macOS Version 12.1 (Build 21C52)
  • Verified when Input amount is 0 tooltip will display Amount must be greater than 0
  • Verified when Address is empty tooltip will display To address is required
1 2
Screen Shot 2022-03-29 at 11 52 51 AM Screen Shot 2022-03-29 at 11 53 03 AM

@kjozwiak kjozwiak mentioned this issue Mar 30, 2022
Closed
@srirambv srirambv mentioned this issue Sep 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.37.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Send Error Improvements with Tooltips brave/brave-core
2 participants
@Uni-verse @Douglashdaniel