Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropped transactions are never retired in our Wallet (Android) #21305

Closed
Pavneet-Sing opened this issue Feb 24, 2022 · 3 comments
Closed

Dropped transactions are never retired in our Wallet (Android) #21305

Pavneet-Sing opened this issue Feb 24, 2022 · 3 comments
Assignees
@simoarpe
Labels
feature/web3/wallet Integrating Ethereum+ wallet support needs-more-info The report requires more detail before we can decide what to do with this issue. OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude

Comments

@Pavneet-Sing
Copy link

Android version of issue 21051-Dropped transactions are never retired in our Wallet.

Handle dropped transaction.
@Pavneet-Sing Pavneet-Sing added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Feb 24, 2022
@Pavneet-Sing Pavneet-Sing self-assigned this Feb 24, 2022
@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Feb 25, 2022
@Pavneet-Sing
Copy link
Author

Pavneet-Sing commented Mar 7, 2022 •
edited
Loading

Update: On hold, as the proposed solution isn't quick enough to produce the 100% desired flow accuracy, although, may work in ideal conditions, with a forever stuck/dropped transaction, so WIP with sporadic discussion

tx.changes.mp4

@bbondy bbondy added this to Web3 Mar 10, 2022
@bbondy bbondy moved this to Backlog in Web3 Mar 16, 2022
@Pavneet-Sing Pavneet-Sing added the needs-more-info The report requires more detail before we can decide what to do with this issue. label Jun 27, 2022
@Pavneet-Sing Pavneet-Sing removed their assignment Oct 5, 2023
@simoarpe simoarpe self-assigned this Oct 24, 2023
@simoarpe simoarpe moved this from Backlog to In Progress in Web3 Oct 31, 2023
@simoarpe simoarpe added blocked priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P2 A bad problem. We might uplift this to the next planned release. blocked labels Nov 1, 2023
@simoarpe simoarpe mentioned this issue Nov 1, 2023
Closed
@simoarpe
Copy link

simoarpe commented Nov 1, 2023

This issue is the Android counterpart of #21051 that is marked with a P3 priority.
I'm lowering the priority to P3 to match #21051 priority, and asked for clarification around current state.

@simoarpe
Copy link

Status update: it's an old issue and is no longer needed since we increased the gas estimations. We can close it.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Nov 13, 2023
@github-project-automation github-project-automation bot moved this to Done/Closed in Android General Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simoarpe simoarpe

Labels
feature/web3/wallet Integrating Ethereum+ wallet support needs-more-info The report requires more detail before we can decide what to do with this issue. OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
Web3
Archived in project
Android General
Status: Done/Closed
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bbondy @simoarpe @Pavneet-Sing