Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect bitfield value is displayed for daily usage pings #21334

Closed
GeetaSarvadnya opened this issue Feb 25, 2022 · 1 comment
Closed

Incorrect bitfield value is displayed for daily usage pings #21334

GeetaSarvadnya opened this issue Feb 25, 2022 · 1 comment

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 25, 2022

Description

Found while testing #20956
Incorrect bitfield value is displayed for daily usage pings

Steps to Reproduce

  1. Clean profile, launch 1.38.1 nightly build
  2. Daily/weekly/monthly usage pings are True which is correct as browser usage pings are sent after browser launch
  3. Verified wallet state is 0 as expected
    image
  4. Close the browser
  5. Set the system date 1 day ahead (I have set it to 26th Feb 2022)
  6. Relaunch the browser and unlock the wallet
  7. Daily/weekly/monthly usage pings are as below
    image (1)
  8. Daily usage ping is true and weekly/monthly usage pings are 0 which is as expected
  9. The wallet bitfield value is 7 (monthly, weekly, daily) instead of 1 (daily) which is incorrect (as per the explanation Fix monthly/weekly wallet usage ping parameter #20956 (comment))

Actual result:

Incorrect bitfield value is displayed for daily usage pings

Expected result:

The wallet bitfield value should be 1 (daily) instead of 7 (monthly, weekly, daily)

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.38.1 Chromium: 99.0.4844.45 (Official Build) nightly (64-bit)
Revision edbc0b8343c7b10fddb0e1b4efb280b0f6e38cab-refs/branch-heads/4844@{#788}
OS Windows 10 Version 21H2 (Build 19044.1526)
## Version/Channel Information:
  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @DJAndries @mattmcalister @brave/legacy_qa

@GeetaSarvadnya
Copy link
Author

The issue is invalid as per my discussion with @DJAndries This works as expected and wallet usage values are totally independent from the browser usage flags (the monthly, weekly, and daily URL parameters). Hence closing the issue as invalid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant