Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-Contribute pref hover state should apply to whole label, not just toggle widget #21377

Open
stephendonner opened this issue Mar 1, 2022 · 1 comment
Assignees

Comments

@stephendonner
Copy link

Description

Auto-Contribute pref hover state should apply to whole label, not just toggle widget

Steps to Reproduce

  1. install 1.38.6
  2. launch Brave
  3. open brave://settings/rewards
  4. hover over the Auto-Contribute label (nothing happens)
  5. hover over its on/off toggle widget

Actual result:

Highlight only is applied to the toggle widget

Screen Shot 2022-02-28 at 10 13 29 PM

Expected result:

Highlight should apply to the whole pref "line," including its label

Screen Shot 2022-02-28 at 10 13 37 PM

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.38.9 Chromium: 99.0.4844.45 (Official Build) nightly (x86_64)
Revision edbc0b8343c7b10fddb0e1b4efb280b0f6e38cab-refs/branch-heads/4844@{#788}
OS macOS Version 11.6.3 (Build 20G415)

cc @GeetaSarvadnya

@zenparsing
Copy link

If we need to add descriptive text we can use the same text that appears on the Rewards settings page.

@zenparsing zenparsing added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants