Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SetSelectedCoin and GetSelectedCoin in mojom #21465

Closed
darkdh opened this issue Mar 4, 2022 · 0 comments · Fixed by brave/brave-core#13261
Closed

Add SetSelectedCoin and GetSelectedCoin in mojom #21465

darkdh opened this issue Mar 4, 2022 · 0 comments · Fixed by brave/brave-core#13261
Assignees
@supermassive
Labels
feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Milestone
1.39.x - Release

Comments

@darkdh
Copy link
Member

darkdh commented Mar 4, 2022 •
edited by yrliou
Loading

We need this pair of API so users can resume to previous panel or page depending on the coin type they left.

In BraveWalletService interface, add SetSelectedCoin(CoinType coin) and GetSelectedCoin() => (CoinType coin), and bind this to a pref.
@darkdh darkdh added feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop feature/web3/wallet/solana labels Mar 4, 2022
@darkdh darkdh added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 4, 2022
@bbondy bbondy added this to Web3 Mar 10, 2022
@bbondy bbondy moved this to Backlog in Web3 Mar 10, 2022
@Douglashdaniel Douglashdaniel mentioned this issue Mar 15, 2022
Merged
24 tasks
@supermassive supermassive moved this from Backlog to In Progress in Web3 Apr 21, 2022
@supermassive supermassive mentioned this issue May 6, 2022
Merged
25 tasks
Repository owner moved this from In Progress to Done in Web3 May 10, 2022
@supermassive supermassive added this to the 1.40.x - Nightly milestone May 12, 2022
@Douglashdaniel Douglashdaniel mentioned this issue May 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@supermassive supermassive

Labels
feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.39.x - Release
Development

Successfully merging a pull request may close this issue.

SelectedCoin pref for KeyringService brave/brave-core
4 participants
@supermassive @bbondy @kjozwiak @darkdh