-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch blinded token requests to use new mywallet endpoint #21516
Comments
@jsecretan can we make sure that the new endpoints are cert-pinned? @diracdeltas |
see here for where ads-serve is currently pinned: https://github.com/brave/brave-core/blob/c215ec61bd7632a1235be014606361d4e2b32fac/chromium_src/net/tools/transport_security_state_generator/input_file_parsers.cc#L460 |
@jsecretan |
@evq @jsecretan if you could let me know if we should be falling back to |
@jsecretan I believe we discussed moving |
@evq is the catalog not geo based? Ok it is not by country/region but it is by country |
@tmancey I didn't think of it from that perspective, but that is a good argument to just consolidate around geo.ads.brave.com and entirely eliminate |
Sounds good to me, sorry for being slow on this, here is the new issue https://github.com/brave/devops/issues/7274 |
Verification passed on
Productiongeo - GET geo.ads.brave.comcatalog - GET static.ads.brave.comissuers - GET static.ads.brave.comunblinded tokens - POST mywallet.ads.brave.comunblinded tokens - GET mywallet.ads.brave.comredeem unblinded tokens - PUT mywallet.ads.brave.comconfirmation - POST anonymous.ads.brave.comconfirmation - paymentToken - GET anonymous.ads.brave.com |
Added |
Verification passed on
Staginggeo - GET geo.ads.bravesoftware.comcatalog - GET static.ads.bravesoftware.comissuers - GET static.ads.bravesoftware.comunblinded tokens - POST mywallet.ads.bravesoftware.comunblinded tokens - GET mywallet.ads.bravesoftware.comredeem unblinded tokens - PUT mywallet.ads.bravesoftware.comconfirmation - POST anonymous.ads.bravesoftware.comconfirmation - paymentToken - GET anonymous.ads.bravesoftware.com |
Description
In order to better specify the privacy properties of the various ads endpoints, we want to change the hostnames to explicitly reflect the specific use according to our privacy policy:
The following endpoints should be reconfigured to go to mywallet.ads.brave.com, with the same path as current
All other endpoints on ads-serve.brave.com should instead go to anonymous.ads.brave.com
Anonymous (
anonymous.ads.*
):GET /v1/issuers/
POST /v2/confirmation/{confirmation_id}/{credential}
GET /v2/confirmation/{confirmation_id}/paymentToken
Non anonymous (
mywallet.ads.*
):PUT /v2/confirmation/payment/{payment_id}
GET /v2/confirmation/token/{payment_id}?nonce={nonce}
POST /v2/confirmation/token/{payment_id}
GET /v{n}/catalog
falls back toads-static
for production environmentGET /v1/getstate
falls back toads-static
for production environmentThe text was updated successfully, but these errors were encountered: