Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add News custom RSS P3A questions #21519

Closed
DJAndries opened this issue Mar 8, 2022 · 2 comments · Fixed by brave/brave-core#12518
Closed

Add News custom RSS P3A questions #21519

DJAndries opened this issue Mar 8, 2022 · 2 comments · Fixed by brave/brave-core#12518
Assignees
@DJAndries
Labels
feature/brave-news formerly brave-today features/P3A OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.39.x - Release

Comments

@DJAndries
Copy link
Collaborator

DJAndries commented Mar 8, 2022 •
edited
Loading

Description

Add two new News P3A questions, for custom RSS feeds:

How many external feeds did you add last week?
Brave.Today.WeeklyAddedDirectFeedsCount

  1. None
  2. 1
  3. 2
  4. 3
  5. 4
  6. 5
  7. 6 to 10
  8. More than 10

How many external feeds do you have in total?
Brave.Today.DirectFeedsTotal

  1. None
  2. 1
  3. 2
  4. 3
  5. 4
  6. 5
  7. 6 to 10
  8. More than 10

Miscellaneous Information:

Will raise PR soon.
@DJAndries DJAndries self-assigned this Mar 8, 2022
@DJAndries DJAndries mentioned this issue Mar 8, 2022
Merged
25 tasks
@DJAndries
Copy link
Collaborator Author

cc @mattmcalister

@mattmcalister mattmcalister added the priority/P2 A bad problem. We might uplift this to the next planned release. label Mar 11, 2022
@DJAndries DJAndries added this to the 1.39.x - Nightly milestone Mar 29, 2022
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 5, 2022 •
edited
Loading

Verification PASSED on


Brave | 1.39.92 Chromium: 101.0.4951.54 (Official Build) beta (64-bit)
-- | --
Revision | 67da1aeb32cedd27634ca6634fb79cbd85d3f0ab-refs/branch-heads/4951@{#1126}
OS | Windows 10 Version 21H2 (Build 19044.1645)

Clean profile

Test plan scenario_PASSED
  • Clean profile 1.39.x
  • Add two RSS feeds via add sources
  • Confirmed that the metrics Brave.Today.DirectFeedsTotal response value is 2 when two custom RSS feeds are added via Brave News->Add source
Add external RSS feed brave://local-state
image image
  • Close the browser
  • Set the system date two days ahead
  • Relaunch the browser and add 5 RSS feeds
  • Reload brave://local-state
  • Confirmed that the metrics Brave.Today.DirectFeedsTotal and Brave.Today.WeeklyAddedDirectFeedsCount response value is 6 as expected
Add external RSS feed brave://local-state
image image
  • Close the browser
  • Set the system date five days ahead
  • Relaunch the browser
  • Reload brave://local-state
  • Confirmed that the metrics Brave.Today.DirectFeedsTotal response value is 6 and Brave.Today.WeeklyAddedDirectFeedsCount response value is 5 as expected

image

  • Close the browser
  • Set the system date three days ahead
  • Relaunch the browser
  • Reload brave://local-state
  • Confirmed that the metrics Brave.Today.DirectFeedsTotal response value is 6 and Brave.Today.WeeklyAddedDirectFeedsCount response value is 0 as expected

image

Brave.Today.DirectFeedsTotal

Case 1: Brave.Today.DirectFeedsTotal = 0_PASSED
  • Confirmed that the metrics Brave.Today.DirectFeedsTotal response value is 0 by default
    image
Case 2: Brave.Today.DirectFeedsTotal = 1_PASSED
  • Clean profile 1.39.x
  • Add external RSS feed via Brave News->Add sources
  • Confirmed that the metrics Brave.Today.DirectFeedsTotal response value is 1when 1 RSS feed is added via Brave News->Add sources
RSS feed brave://local-state
image image
Case 3: Brave.Today.DirectFeedsTotal = 2_PASSED
  • Clean profile 1.39.x
  • Add 2 external RSS feed via Brave News->Add sources
  • Confirmed that the metrics Brave.Today.DirectFeedsTotal response value is 2when 2 RSS feed are added via Brave News->Add sources
RSS feed brave://local-state
image image
Case 4: Brave.Today.DirectFeedsTotal = 3_PASSED
  • Clean profile 1.39.x
  • Add 3 external RSS feed via Brave News->Add sources
  • Confirmed that the metrics Brave.Today.DirectFeedsTotal response value is 3when 3 RSS feed are added via Brave News->Add sources
RSS feed brave://local-state
image image
Case 5: Brave.Today.DirectFeedsTotal = 4_PASSED
  • Clean profile 1.39.x
  • Add 4 external RSS feed via Brave News->Add sources
  • Confirmed that the metrics Brave.Today.DirectFeedsTotal response value is 4when 4 RSS feed are added via Brave News->Add sources
RSS feed brave://local-state
image image
Case 6: Brave.Today.DirectFeedsTotal = 5_PASSED
  • Clean profile 1.39.x
  • Add 5 external RSS feed via Brave News->Add sources
  • Confirmed that the metrics Brave.Today.DirectFeedsTotal response value is 5when 5 RSS feed are added via Brave News->Add sources
RSS feed brave://local-state
image image
Case 7: Brave.Today.DirectFeedsTotal = 6_PASSED

Case 1:

  • Clean profile 1.39.x
  • Add 6 external RSS feed via Brave News->Add sources
  • Confirmed that the metrics Brave.Today.DirectFeedsTotal response value is 6when 6 RSS feed are added via Brave News->Add sources
RSS feed brave://local-state
image image

Case 2:

  • Clean profile 1.39.x
  • Add 10 external RSS feed via Brave News->Add sources
  • Confirmed that the metrics Brave.Today.DirectFeedsTotal response value is 6when 10 RSS feed are added via Brave News->Add sources
RSS feed brave://local-state
image image
Case 8: Brave.Today.DirectFeedsTotal = 7_PASSED
  • Clean profile 1.39.x
  • Add more than 10 external RSS feed via Brave News->Add sources
  • Confirmed that the metrics Brave.Today.DirectFeedsTotal response value is 7when more than 10 RSS feed are added via Brave News->Add sources
RSS feed brave://local-state
image image

Brave.Today.WeeklyAddedDirectFeedsCount

Case 1: Brave.Today.WeeklyAddedDirectFeedsCount = 0_PASSED
  • Confirmed that the metrics Brave.Today.WeeklyAddedDirectFeedsCount response value is 0 by default
    image
Case 2: Brave.Today.WeeklyAddedDirectFeedsCount = 1_PASSED
  • Clean profile 1.39.x
  • Add an RSS feeds via add sources
  • Confirmed that the metrics Brave.Today.WeeklyAddedDirectFeedsCount response value is 1 when one custom RSS feeds is added via Brave News->Add source
  • Close the browser
  • Set the system date ahead by a week
  • Relaunch the browser and ensure that the metrics Brave.Today.WeeklyAddedDirectFeedsCount response value is still 1 as expected [because one week is still not elapsed hence the WeeklyAddedDirectFeedsCount is 1]
    image
  • Close the browser and set the system date ahead by 1 day [7+1 = 8th day]
  • Relaunch the browser and reload brave://local-state
  • Confirmed that the metrics Brave.Today.WeeklyAddedDirectFeedsCount response value is 0 as expected [because one week is elapsed hence the WeeklyAddedDirectFeedsCount is 0]
    image
Case 3: Brave.Today.WeeklyAddedDirectFeedsCount = 2_PASSED
  • Clean profile 1.39.x
  • Add 2 RSS feeds via add sources
  • Confirmed that the metrics Brave.Today.WeeklyAddedDirectFeedsCount response value is 2 when 2 custom RSS feeds are added via Brave News->Add source
  • Close the browser
  • Set the system date ahead by a week
  • Relaunch the browser and ensure that the metrics Brave.Today.WeeklyAddedDirectFeedsCount response value is still 2 as expected [because one week is still not elapsed hence the WeeklyAddedDirectFeedsCount is 2]
    image
  • Close the browser and set the system date ahead by 1 day [7+1 = 8th day]
  • Relaunch the browser and reload brave://local-state
  • Confirmed that the metrics Brave.Today.WeeklyAddedDirectFeedsCount response value is 0 as expected [because one week is elapsed hence the WeeklyAddedDirectFeedsCount is 0]
    image
Case 4: Brave.Today.WeeklyAddedDirectFeedsCount = 3_PASSED
  • Clean profile 1.39.x
  • Add 3 RSS feeds via add sources
  • Confirmed that the metrics Brave.Today.WeeklyAddedDirectFeedsCount response value is 3 when 3 custom RSS feeds are added via Brave News->Add source
  • Close the browser
  • Set the system date ahead by a week
  • Relaunch the browser and ensure that the metrics Brave.Today.WeeklyAddedDirectFeedsCount response value is still 3 as expected [because one week is still not elapsed hence the WeeklyAddedDirectFeedsCount is 3]
    image
  • Close the browser and set the system date ahead by 1 day [7+1 = 8th day]
  • Relaunch the browser and reload brave://local-state
  • Confirmed that the metrics Brave.Today.WeeklyAddedDirectFeedsCount response value is 0 as expected [because one week is elapsed hence the WeeklyAddedDirectFeedsCount is 0]
    image
Case 5: Brave.Today.WeeklyAddedDirectFeedsCount = 4_PASSED
  • Clean profile 1.39.x
  • Add 4 RSS feeds via add sources
  • Confirmed that the metrics Brave.Today.WeeklyAddedDirectFeedsCount response value is 4 when 4 custom RSS feeds are added via Brave News->Add source
  • Close the browser
  • Set the system date ahead by a week
  • Relaunch the browser and ensure that the metrics Brave.Today.WeeklyAddedDirectFeedsCount response value is still 4 as expected [because one week is still not elapsed hence the WeeklyAddedDirectFeedsCount is 4]
    image
  • Close the browser and set the system date ahead by 1 day [7+1 = 8th day]
  • Relaunch the browser and reload brave://local-state
  • Confirmed that the metrics Brave.Today.WeeklyAddedDirectFeedsCount response value is 0 as expected [because one week is elapsed hence the WeeklyAddedDirectFeedsCount is 0]
    image
Case 6: Brave.Today.WeeklyAddedDirectFeedsCount = 5_PASSED
  • Clean profile 1.39.x
  • Add 5 RSS feeds via add sources
  • Confirmed that the metrics Brave.Today.WeeklyAddedDirectFeedsCount response value is 5 when 5 custom RSS feeds are added via Brave News->Add source
  • Close the browser
  • Set the system date ahead by a week
  • Relaunch the browser and ensure that the metrics Brave.Today.WeeklyAddedDirectFeedsCount response value is still 5 as expected [because one week is still not elapsed hence the WeeklyAddedDirectFeedsCount is 5]
    image
  • Close the browser and set the system date ahead by 1 day [7+1 = 8th day]
  • Relaunch the browser and reload brave://local-state
  • Confirmed that the metrics Brave.Today.WeeklyAddedDirectFeedsCount response value is 0 as expected [because one week is elapsed hence the WeeklyAddedDirectFeedsCount is 0]
    image
Case 7: Brave.Today.WeeklyAddedDirectFeedsCount = 6_PASSED

Case 1:

  • Clean profile 1.39.x
  • Add 6 RSS feeds via add sources
  • Confirmed that the metrics Brave.Today.WeeklyAddedDirectFeedsCount response value is 6 when 6 custom RSS feeds are added via Brave News->Add source
  • Close the browser
  • Set the system date ahead by a week
  • Relaunch the browser and ensure that the metrics Brave.Today.WeeklyAddedDirectFeedsCount response value is still 6 as expected [because one week is still not elapsed hence the WeeklyAddedDirectFeedsCount is 6]
    image
  • Close the browser and set the system date ahead by 1 day [7+1 = 8th day]
  • Relaunch the browser and reload brave://local-state
  • Confirmed that the metrics Brave.Today.WeeklyAddedDirectFeedsCount response value is 0 as expected [because one week is elapsed hence the WeeklyAddedDirectFeedsCount is 0]
    image

Case 2:

  • Clean profile 1.39.x
  • Add 10 RSS feeds via add sources
  • Confirmed that the metrics Brave.Today.WeeklyAddedDirectFeedsCount response value is 6 when 6 custom RSS feeds are added via Brave News->Add source
  • Close the browser
  • Set the system date ahead by a week
  • Relaunch the browser and ensure that the metrics Brave.Today.WeeklyAddedDirectFeedsCount response value is still 6 as expected [because one week is still not elapsed hence the WeeklyAddedDirectFeedsCount is 6]
    image
  • Close the browser and set the system date ahead by 1 day [7+1 = 8th day]
  • Relaunch the browser and reload brave://local-state
  • Confirmed that the metrics Brave.Today.WeeklyAddedDirectFeedsCount response value is 0 as expected [because one week is elapsed hence the WeeklyAddedDirectFeedsCount is 0]
    image
Case 8: Brave.Today.WeeklyAddedDirectFeedsCount = 7_PASSED
  • Clean profile 1.39.x
  • Add more than 10 RSS feeds via add sources
  • Confirmed that the metrics Brave.Today.WeeklyAddedDirectFeedsCount response value is 7 when more than 10 custom RSS feeds are added via Brave News->Add source
  • Close the browser
  • Set the system date ahead by a week
  • Relaunch the browser and ensure that the metrics Brave.Today.WeeklyAddedDirectFeedsCount response value is still 7 as expected [because one week is still not elapsed hence the WeeklyAddedDirectFeedsCount is 7]
    image
  • Close the browser and set the system date ahead by 1 day [7+1 = 8th day]
  • Relaunch the browser and reload brave://local-state
  • Confirmed that the metrics Brave.Today.WeeklyAddedDirectFeedsCount response value is 0 as expected [because one week is elapsed hence the WeeklyAddedDirectFeedsCount is 0]
    image

Upgrade profile

Case 1: Brave.Today.DirectFeedsTotal = 0_PASSED
  • Clean profile 1.38.x beta channel
  • Open brave://local-state
  • Confirmed that the metrics Brave.Today.DirectFeedsTotal is NOT shown in brave://local-state
  • Upgrade the profile to 1.39.x beta channel
  • Open brave://local-state
  • Confirmed that the metrics Brave.Today.DirectFeedsTotal response value is 0 as expected
Case 2: Brave.Today.DirectFeedsTotal = 1_PASSED
  • Clean profile 1.38.x beta channel
  • Open brave://local-state
  • Confirmed that the metrics Brave.Today.DirectFeedsTotal is NOT shown in brave://local-state
  • Add a single RSS feed via Brave News->Add sources
  • Upgrade the profile to 1.39.x beta channel
  • Open brave://local-state
  • Confirmed that the metrics Brave.Today.DirectFeedsTotal response value is 1 as expected
RSS Feed - 1.37.x brave://local-state - 1.38.x
image image
Case 1: Brave.Today.WeeklyAddedDirectFeedsCount = 0_PASSED
  • Clean profile 1.38.x beta channel
  • Open brave://local-state
  • Confirmed that the metrics Brave.Today.WeeklyAddedDirectFeedsCount is NOT shown in brave://local-state
  • Upgrade the profile to 1.39.x beta channel
  • Open brave://local-state
  • Confirmed that the metrics Brave.Today.WeeklyAddedDirectFeedsCount response value is 0 as expected
Case 2: Brave.Today.WeeklyAddedDirectFeedsCount = 1_FAILED Logged https://github.com//issues/22709

@GeetaSarvadnya GeetaSarvadnya mentioned this issue May 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DJAndries DJAndries

Labels
feature/brave-news formerly brave-today features/P3A OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.39.x - Release
Development

Successfully merging a pull request may close this issue.

Add News custom RSS feed P3A questions, refactor News P3A brave/brave-core
3 participants
@mattmcalister @DJAndries @GeetaSarvadnya