Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling Tor mode by default (under Properties) opens 2 windows #21579

Closed
ShadowOne333 opened this issue Mar 10, 2022 · 8 comments · Fixed by brave/brave-core#16357
Closed

Enabling Tor mode by default (under Properties) opens 2 windows #21579

ShadowOne333 opened this issue Mar 10, 2022 · 8 comments · Fixed by brave/brave-core#16357

Comments

@ShadowOne333
Copy link

Description

Adding the --tor argument at the end of the "Target" box opens up two Brave Private Tor windows, instead of just one,
This behaviour is also mirrored if trying to add the --tor argument in Brave's pinned icon in the Taskbar.

Steps to Reproduce

  1. Right click on the Brave browser's icon, either under Desktop or the pinned icon on Taskbar (Windows 10)
  2. Select "Properties"
  3. Add the --tor argument at the end of the path found in the Shortcut tab inside the target box. Ex: "C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe" --tor
  4. Apply and save the changes
  5. Try opening up Brave with Private+Tor by double clicking on the Desktop icon, or clicking on the pinned icon on the Taskbar.
  6. Brave will open up 2 windows instead of only one. (Tor and Tor 2)

Expected result:

Opening Brave after making the change to open Tor mode by default should open up only one window.

Reproduces how often:

Easily reproduced each time one tries to open Brave after making the changes, both by clicking on the Desktop icon and by clicking on the pinned icon in Taskbar.

Brave version (brave://version info)

Brave | 1.36.111 Chromium: 99.0.4844.51 (Official Build) (64-bit)
Revision | d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS | Windows 10 Version 21H1 (Build 19043.1586)

Other Additional Information:

Using the --incognito argument instead of --tor opens up a single window, as expected.
It's only the --tor argument that causes the issue.

@86x
Copy link

86x commented Mar 11, 2022

can confirm this happens with the current linux version, too. To add to the story, this behavior seems to be new since I am 100% sure that previously only one window was opened when using the --tor option. The --incognito option continues to work properly btw.

brave-browser --version output:
Brave Browser 99.1.36.111

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Mar 15, 2022
@ShadowOne333
Copy link
Author

I'd also like to ask if there's a way to automatically start Brave in either Incognito or Tor mode in Linux, as it doesn't have a way to modify the argument given to it when opening it from the Activities overview or as an icon in favorites/Applications list.

@0rphee
Copy link

0rphee commented Jun 10, 2022

I can confirm this also happens in MacOS when opening from the terminal
$ ./Brave\ Browser.app/Contents/MacOS/Brave\ Browser --tor

MacOS 12.4 (21F79)
Brave Version: 1.39.122 Chromium: 102.0.5005.115 (Official Build) (arm64)

@Dyras
Copy link

Dyras commented Jun 22, 2022

Thread on the Brave forum about this: https://community.brave.com/t/opening-tor-with-terminal-opens-2-tor-window/356755

@stephendonner
Copy link

Verified PASSED using

Brave 1.48.81 Chromium: 109.0.5414.46 (Official Build) nightly (x86_64)
Revision 6e36b77363ef3febbe792af680fa1367993ddcf0-refs/branch-heads/5414@{#709}
OS macOS Version 13.2 (a) (Build 22D7750270d)

Steps:

  1. installed 1.48.81
  2. launched Brave using --tor on the commandline

Confirmed I only got one new Private Window with Tor

1.48.81 1.46.44
Screenshot 2022-12-22 at 11 00 11 PM Screenshot 2022-12-22 at 11 18 20 PM

@btlechowski
Copy link

QA/Test-All-Platforms as each platform handles windows differently.

@MadhaviSeelam
Copy link

MadhaviSeelam commented Jan 19, 2023

Verification PASSED using

Brave | 1.48.132 Chromium: 109.0.5414.87 (Official Build) beta (64-bit)
-- | --
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Windows 11 Version 21H2 (Build 22000.1455)

Steps:

installed 1.48.132
launched Brave using --tor on the commandline

Confirmed I only got one new Private Window with Tor

1.48.132 1.47.177
image image

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.48.132 Chromium: 109.0.5414.87 (Official Build) beta (64-bit)
-- | --
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Linux

Steps:

  • installed 1.48.132
  • launched Brave using --tor on the commandline

Confirmed I only got one new Private Window with Tor

1.48.132 1.47.171
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment