Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirmation state in swap #21637

Closed
jamesmudgett opened this issue Mar 14, 2022 · 1 comment · Fixed by brave/brave-core#15079
Closed

Confirmation state in swap #21637

jamesmudgett opened this issue Mar 14, 2022 · 1 comment · Fixed by brave/brave-core#15079
Assignees
@onyb
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.46.x - Release

Comments

@jamesmudgett
Copy link

After clicking swap the swap widget should change from the input state to a pending transaction state that gives some progress/status on the pending swap. Could also be bypassed to perform an other swap.
@jamesmudgett jamesmudgett added design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Mar 14, 2022
@bbondy bbondy added the front-end-change This task is a front end task and doesn't need any C++ changes label Mar 18, 2022
@bbondy bbondy added this to Web3 Mar 18, 2022
@bbondy bbondy moved this to Backlog in Web3 Mar 18, 2022
@onyb onyb mentioned this issue Sep 13, 2022
Merged
25 tasks
Repository owner moved this from Backlog to Done in Web3 Sep 23, 2022
@onyb onyb added this to the 1.46.x - Nightly milestone Sep 23, 2022
@onyb onyb self-assigned this Sep 23, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.46.70 Chromium: 107.0.5304.36 (Official Build) beta (64-bit)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS Linux
21637.mp4

Verification passed on

Brave 1.46.70 Chromium: 107.0.5304.36 (Official Build) beta (64-bit)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS Windows 11 Version 22H2 (Build 22621.674)
21637.mp4

Verification passed on

Brave 1.46.70 Chromium: 107.0.5304.36 (Official Build) beta (arm64)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS macOS Version 13.0 (Build 22A380)
21637.mov

@LaurenWags LaurenWags mentioned this issue Nov 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.46.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): hook status screens into transaction confirmation panel brave/brave-core
4 participants
@jamesmudgett @bbondy @onyb @srirambv