Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0x Swaps should compare against CoinGecko for bad prices #21704

Closed
bbondy opened this issue Mar 16, 2022 · 2 comments · Fixed by brave/brave-core#15762
Closed

0x Swaps should compare against CoinGecko for bad prices #21704

bbondy opened this issue Mar 16, 2022 · 2 comments · Fixed by brave/brave-core#15762
Assignees
@onyb
Labels
feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.48.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Mar 16, 2022 •
edited
Loading

In the back-end swap API we should check our CG proxy to compare the swap price to make sure the user is getting a good price within some threshold. Maybe 5%?

The back-end should add a hint to the front end that the price is not good.
@bbondy bbondy added OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality labels Mar 16, 2022
@bbondy bbondy added this to Web3 Mar 16, 2022
@bbondy bbondy added the priority/P4 Planned work. We expect to get to it "soon". label Mar 16, 2022
@bbondy bbondy moved this to Backlog in Web3 Mar 16, 2022
@onyb onyb moved this from Backlog to In Review in Web3 Nov 9, 2022
@onyb onyb self-assigned this Nov 9, 2022
@onyb onyb mentioned this issue Nov 9, 2022
Merged
25 tasks
Repository owner moved this from In Review to Done in Web3 Nov 28, 2022
@onyb onyb added this to the 1.48.x - Nightly milestone Nov 28, 2022
@onyb onyb added the QA/Yes label Nov 28, 2022
@onyb
Copy link
Member

onyb commented Nov 28, 2022

This is now available in Swap V2. Head over to brave://wallet/swap to test.

@onyb onyb added release-notes/include and removed OS/Android Fixes related to Android browser functionality OS/iOS Fixes related to iOS browser functionality labels Nov 28, 2022
@srirambv srirambv added the feature/web3/wallet Integrating Ethereum+ wallet support label Jan 10, 2023
@srirambv
Copy link
Contributor

Verified as part of #26632 (comment)

@LaurenWags LaurenWags mentioned this issue Feb 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.48.x - Release
Development

Successfully merging a pull request may close this issue.

feat(swap): add Swap v2 integration brave/brave-core
4 participants
@bbondy @onyb @HEagle18 @srirambv