Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from C99 -> C100 on ARM x64 for 1.38.x - Nightly (Checking C100) #21741

Closed
25 tasks done
kjozwiak opened this issue Mar 17, 2022 · 1 comment
Closed
25 tasks done
Assignees
Labels
ARM Android ARM related issues OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/exclude tests

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Mar 17, 2022

As per process, QA runs through the following cases to ensure that the major chromium bump that's about to get merged into master doesn't regress the Nightly channel. Once the major chromoium bump is merged into master, QA will run through a full manual pass on Windows & Android.

Startup & Components

  • Verify that Brave is only contacting *.brave.com endpoints on first launch using either Charles Proxy, Fiddler, Wireshark or LittleSnitch (or a similar application)
    • Verify that opening a NTP doesn't trigger any outbound connections related to widgets without user interaction
  • Restart the browser, load brave://components, wait for 8 mins and verify that no component shows any errors

Note: Always double check brave://components to make sure there's no errors/missing version numbers. We basically want to make sure that components are working as they regressed in C98 when we first merged into master.

Upgrade

  • Make sure that data from the last version appears in the new version OK
  • Ensure that brave://version lists the expected Brave & Chromium versions
  • With data from the last version, verify that:
    • Bookmarks on the bookmark toolbar and bookmark folders can be opened
    • Cookies are preserved
    • Installed extensions are retained and work correctly
    • Opened tabs can be reloaded
    • Stored passwords are preserved
    • Sync chain created in previous version is retained
    • Social media-blocking buttons changes are retained
    • Rewards
      • Wallet balance is retained
      • Auto-contribute list is retained
      • Both Tips and Monthly Contributions are retained
      • Wallet panel transactions list is retained
      • Changes to rewards settings are retained
      • Ensure that Auto Contribute is not being enabled when upgrading to a new version if AC was disabled
    • Ads
      • Both Estimated pending rewards & Ad notifications received this month are retained
      • Changes to ads settings are retained
      • Ensure that ads are not being enabled when upgrading to a new version if they were disabled
      • Ensure that ads are not disabled when upgrading to a new version if they were enabled
@kjozwiak kjozwiak added tests QA/Yes release-notes/exclude OS/Android Fixes related to Android browser functionality ARM Android ARM related issues labels Mar 17, 2022
@kjozwiak kjozwiak added this to the 1.38.x - Nightly milestone Mar 17, 2022
@Uni-verse Uni-verse self-assigned this Mar 17, 2022
@Uni-verse
Copy link
Contributor

Uni-verse commented Mar 18, 2022

Verification Completed using build:

1.38.52 Chromium: 100.0.4896.46 (Official Build) canary (32-bit) 
Revision	5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS	Android 12; Build/SP1A.210812.016

Device: Samsung GS 21

Version Components
Screen Shot 2022-03-17 at 2 53 49 PM Screen Shot 2022-03-18 at 12 34 40 AM

Triple checked and it seems like theres an error for one of the components. Not sure if this is expected. (Update: Looks like this is observed in the C99 build as well)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARM Android ARM related issues OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/exclude tests
Projects
None yet
Development

No branches or pull requests

2 participants