Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open Rewards onboarding tour from NTP widget #21811

Closed
rebron opened this issue Mar 22, 2022 · 3 comments · Fixed by brave/brave-core#12699
Closed

Open Rewards onboarding tour from NTP widget #21811

rebron opened this issue Mar 22, 2022 · 3 comments · Fixed by brave/brave-core#12699
Assignees
@zenparsing
Labels
feature/rewards OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude retention
Milestone
1.38.x - Release

Comments

@rebron
Copy link
Collaborator

rebron commented Mar 22, 2022 •
edited
Loading

Description

When users select "Start using Rewards" from the NTP Brave Rewards widget, we should open the Brave Rewards panel and show users the Rewards onboarding tour.

Steps to Reproduce

  1. Install latest version of browser or create a new profile
  2. Notice Brave Rewards panel and select Start using Rewards button.
  3. Brave Rewards panel changes to 0.00, etc. Users should be taken to Rewards tour.

Actual result:

Screenshot 2022-03-22 081539

Expected result:

Screenshot 2022-03-22 081121

Screenshot 2022-03-22 081156

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc: @Miyayes
@rebron rebron mentioned this issue Mar 22, 2022
Closed
@rebron rebron mentioned this issue Mar 22, 2022
Closed
@zenparsing zenparsing mentioned this issue Mar 22, 2022
Merged
25 tasks
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude labels Mar 22, 2022
@Miyayes Miyayes mentioned this issue Mar 22, 2022
Closed
@zenparsing zenparsing added this to the 1.38.x - Nightly milestone Mar 23, 2022
@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 30, 2022
@MadhaviSeelam
Copy link

MadhaviSeelam commented Mar 31, 2022 •
edited
Loading

Brave 1.38.74 Chromium: 100.0.4896.60 (Official Build) beta (64-bit)
Revision 6a5d10861ce8de5fce22564658033b43cb7de047-refs/branch-heads/4896@{#875}
OS Windows 11 Version 21H2 (Build 22000.593)
Testcase 1: Rewards onboarding tour should be shown when clicked on 'Start using Rewards` from NTP Brave Rewards widget
  • Install 1.38.74
  • Launch Brave
  • Set Brave as default on the first run dialog
  • Click Skip welcome tour
  • Click Start using Rewards on the Brave Rewards Panel on NTP
  • Rewards Onboarding tour is shown
  • Complete the tour
ex1 ex2
NTP Rewards widget NTP rewards widget tour
Testcase 2: Rewards onboarding tour will not be shown from NTP widget once `Start Using Rewards` was clicked previously

Pre requisites:

  1. User has previously clicked Start using Rewards button on NTP Rewards widget
  2. User has previously clicked NTP SI Brave Rewards widget
  • Launch a new profile
  • Clicked Start using Rewards button from prerequisites options
  • Disable Ads from brave://rewards
  • Return back to NTP and Brave Rewards widget shows Start using Rewards
  • Click Start using Rewards
  • Rewards tour is not shown
ex1 ex2 ex3
Ads disabled NTP tour is not shown NTPSI rewards tooltip
Testcase 3: Rewards onboarding tour will be shown from NTP Rewards widget even if the user has completed rewards tour from Brave Rewards panel
  • New profile
  • Launch Brave
  • Set Brave as default on the first run dialog
  • Click Skip welcome tour
  • Click on the Rewards icon in the URL and complete onboarding tour from Brave Rewards panel
  • Start Using Rewards button will be disappeared form Brave Rewards widget on NTP
  • Disable Ads from brave://rewards
  • Open a NTP and Click Start using Rewards
  • Rewards onboarding tour is displayed
ex1 ex2 ex3 ex4
Rewards tour from BRE Disable Ads ntp NTP rewards widget tour
Testcase 4: Rewards onboarding tour will be shown from NTP widget even if the user has completed rewards tour from the Rewards page
  • New profile
  • Launch Brave
  • Set Brave as default on the first run dialog
  • Click Skip welcome tour
  • Open brave://rewards
  • Click Start using Brave Rewards and complete onboarding tour
  • Disable Ads in brave://settings/rewards
  • Open NTP and Click Start using Rewards
  • Rewards Onboarding tour should be displayed
ex1 ex2 ex3 ex4 ex5
start using rewards from brave rewards onboarding tour from brave rewards page Ads disabled <NTP rewards widget rewards button Complete tour from NTP

@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 31, 2022
@stephendonner
Copy link

stephendonner commented Apr 8, 2022 •
edited
Loading

Verification IN-PROGRESS using

Brave 1.38.83 Chromium: 100.0.4896.79 (Official Build) beta (x86_64)
Revision 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS macOS Version 11.6.5 (Build 20G527)
Testcase 1: Rewards onboarding tour should be shown when clicked on Start using Rewards from NTP Brave Rewards widget
  • Install 1.38.83
  • Launch Brave
  • Set Brave as default on the first run dialog
  • Click Skip welcome tour
  • Click Start using Rewards on the Brave Rewards Panel on NTP
  • Rewards Onboarding tour is shown
  • Complete the tour
ex1 ex2 ex3
Screen Shot 2022-04-07 at 5 50 29 PM Screen Shot 2022-04-07 at 5 50 43 PM Screen Shot 2022-04-07 at 5 50 46 PM
Testcase 2: Rewards onboarding tour will not be shown from NTP widget once Start Using Rewards was clicked previously

Prerequisites:

  1. User has previously clicked Start using Rewards button on NTP Rewards widget
  2. User has previously clicked NTP SI Brave Rewards widget
  • Launch a new profile
  • Clicked Start using Rewards button from prerequisites options
  • Disable Ads from brave://rewards
  • Return back to NTP and Brave Rewards widget shows Start using Rewards
  • Click Start using Rewards
  • Rewards tour is not shown
ex1 ex2 ex3
Screen Shot 2022-04-07 at 5 59 16 PM Screen Shot 2022-04-07 at 6 00 24 PM Screen Shot 2022-04-07 at 6 01 06 PM
Testcase 3: Rewards onboarding tour will be shown from NTP Rewards widget even if the user has completed rewards tour from Brave Rewards panel
  • New profile
  • Launch Brave
  • Set Brave as default on the first run dialog
  • Click Skip welcome tour
  • Click on the Rewards icon in the URL and complete onboarding tour from Brave Rewards panel
  • Start Using Rewards button will be disappeared form Brave Rewards widget on NTP
  • Disable Ads from brave://rewards
  • Open a NTP and Click Start using Rewards
  • Rewards onboarding tour is displayed
ex1 ex2 ex3 ex4
Screen Shot 2022-04-07 at 6 13 21 PM Screen Shot 2022-04-07 at 6 15 53 PM Screen Shot 2022-04-07 at 6 16 15 PM Screen Shot 2022-04-07 at 6 16 30 PM
Testcase 4: Rewards onboarding tour will be shown from NTP widget even if the user has completed rewards tour from the Rewards page
  • New profile
  • Launch Brave
  • Set Brave as default on the first run dialog
  • Click Skip welcome tour
  • Open brave://rewards
  • Click Start using Brave Rewards and complete onboarding tour
  • Disable Ads in brave://settings/rewards
  • Open NTP and Click Start using Rewards
  • Rewards Onboarding tour should be displayed
ex1 ex2 ex3 ex4 ex5
Screen Shot 2022-04-07 at 6 21 11 PM Screen Shot 2022-04-07 at 6 22 16 PM Screen Shot 2022-04-07 at 6 22 28 PM Screen Shot 2022-04-07 at 6 23 07 PM Screen Shot 2022-04-07 at 6 23 21 PM

@btlechowski
Copy link

Verification passed on

Brave 1.38.83 Chromium: 100.0.4896.79 (Official Build) beta (64-bit)
Revision 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS Ubuntu 18.04 LTS
Testcase 1: Rewards onboarding tour should be shown when clicked on Start using Rewards from NTP Brave Rewards widget
  • Install 1.38.83
  • Launch Brave
  • Set Brave as default on the first run dialog
  • Click Skip welcome tour
  • Click Start using Rewards on the Brave Rewards Panel on NTP
  • Rewards Onboarding tour is shown
  • Complete the tour

image
image
image

Testcase 2: Rewards onboarding tour will not be shown from NTP widget once Start Using Rewards was clicked previously

Prerequisites:

  1. User has previously clicked Start using Rewards button on NTP Rewards widget
  2. User has previously clicked NTP SI Brave Rewards widget
  • Launch a new profile
  • Clicked Start using Rewards button from prerequisites options
  • Disable Ads from brave://rewards
  • Return back to NTP and Brave Rewards widget shows Start using Rewards
  • Click Start using Rewards
  • Rewards tour is not shown

image
image
image

Testcase 3: Rewards onboarding tour will be shown from NTP Rewards widget even if the user has completed rewards tour from Brave Rewards panel
  • New profile
  • Launch Brave
  • Set Brave as default on the first run dialog
  • Click Skip welcome tour
  • Click on the Rewards icon in the URL and complete onboarding tour from Brave Rewards panel
  • Start Using Rewards button will be disappeared form Brave Rewards widget on NTP
  • Disable Ads from brave://rewards
  • Open a NTP and Click Start using Rewards
  • Rewards onboarding tour is displayed

image
image
image
image

Testcase 4: Rewards onboarding tour will be shown from NTP widget even if the user has completed rewards tour from the Rewards page
  • New profile
  • Launch Brave
  • Set Brave as default on the first run dialog
  • Click Skip welcome tour
  • Open brave://rewards
  • Click Start using Brave Rewards and complete onboarding tour
  • Disable Ads in brave://settings/rewards
  • Open NTP and Click Start using Rewards
  • Rewards Onboarding tour should be displayed

image
image
image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zenparsing zenparsing

Labels
feature/rewards OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude retention
Projects
None yet
Milestone
1.38.x - Release
Development

Successfully merging a pull request may close this issue.

Open Rewards onboarding tour from the NTP brave/brave-core
6 participants
@stephendonner @rebron @zenparsing @LaurenWags @btlechowski @MadhaviSeelam