Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove widget from Android new tab page #21826

Closed
bsclifton opened this issue Mar 23, 2022 · 4 comments · Fixed by brave/brave-core#12743
Closed

Remove widget from Android new tab page #21826

bsclifton opened this issue Mar 23, 2022 · 4 comments · Fixed by brave/brave-core#12743
Assignees
Labels
feature/brave-news formerly brave-today feature/new-tab OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude

Comments

@bsclifton
Copy link
Member

Description

Let's revert to what we had before the widget. Basically:

  • stats shows at top (not as a widget)
  • 4 top site tiles show by default
  • If you disable backgrounds, 8 top sites will show

This is already partially implemented; you can see that code branch if you remove ALL widgets and disable backgrounds. It will show the stats at top and 8 tiles.

Removing the widget will solve the following issues:

As a follow up, we can then do #13714 (maybe showing a Show more similar to iOS)

@bsclifton bsclifton added the OS/Android Fixes related to Android browser functionality label Mar 23, 2022
@alexsafe
Copy link

This is how it looks rn:

Screenshot_20220323-160228
Screenshot_20220323-160215

The translucent background is based on the Slack convos and the referenced figma. Obviously there is no frost glass effect since it's on iOS thing (it CAN be done Android too, but it's custom)

Opinions?

cc @anthonypkeane @bradleyrichter @bsclifton

@bradleyrichter
Copy link

perfect @alexsafe !

@kjozwiak
Copy link
Member

The above will require 1.38.105 or higher for 1.38.x verification 👍

@Uni-verse
Copy link
Contributor

Uni-verse commented Apr 22, 2022

Verified using 1.38.105, Chromium 101.0.4951.41

Devices:
Samsung Galaxy S21 | Android 12
Samsung Galaxy Tab S7 | Android 12

  • Confirmed widget is removed from new tab page.
  • Performed upgrade scenario 1.37.116 -> 1.38.105 to ensure the widget is gone.
Tablet Mobile
Screen Shot 2022-04-22 at 2 20 12 PM Screen Shot 2022-04-22 at 2 06 15 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/brave-news formerly brave-today feature/new-tab OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants