Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggle password visibility button gets focused #21845

Closed
supermassive opened this issue Mar 24, 2022 · 1 comment · Fixed by brave/brave-core#13273
Closed

Toggle password visibility button gets focused #21845

supermassive opened this issue Mar 24, 2022 · 1 comment · Fixed by brave/brave-core#13273
Assignees
@supermassive
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.40.x - Release

Comments

@supermassive
Copy link

Description

Need to press Tab key twice to switch from Password field to Confirm Password field.

Steps to Reproduce

  1. Start restoring wallet on brave://wallet
  2. Type something in Password field
  3. Press tab

Actual result:

Input cursor disappears

Expected result:

Input cursor should appear in Confirm Password field

Reproduces how often:

Easily reproduced

Version/Channel Information:

  • Brave Nightly
@supermassive supermassive added QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Mar 24, 2022
@supermassive supermassive added this to the 1.39.x - Nightly milestone Mar 24, 2022
This was referenced Mar 24, 2022
Closed
Closed
@yrliou yrliou removed this from the 1.39.x - Nightly milestone Mar 24, 2022
@yrliou yrliou added this to Web3 Mar 24, 2022
@yrliou yrliou moved this to In Review in Web3 Mar 24, 2022
@supermassive supermassive mentioned this issue May 10, 2022
Merged
25 tasks
Repository owner moved this from In Review to Done in Web3 May 13, 2022
@supermassive supermassive added this to the 1.40.x - Nightly milestone May 13, 2022
@srirambv
Copy link
Contributor

Brave 1.40.68 Chromium: 102.0.5005.50 (Official Build) beta (64-bit)
Revision f6e2cf8f59ec714bdcff8499991d55898875f287-refs/branch-heads/5005@{#648}
OS ☑️ Linux ☑️ Windows 11 Version 22H2
(Build 22621.1) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#13273
  • Verified pressing tab in password field sets focus to show/hide password button
21845-Linux.mp4
21845-Windows.mov
21845-macOS.mov

@kjozwiak kjozwiak mentioned this issue Jun 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@supermassive supermassive

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.40.x - Release
3 participants
@supermassive @yrliou @srirambv