Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Themes stay enabled in incognito mode, but with dark bar icons #2219

Open
euclaise opened this issue Nov 23, 2018 · 1 comment
Open

Themes stay enabled in incognito mode, but with dark bar icons #2219

euclaise opened this issue Nov 23, 2018 · 1 comment
Labels
design A design change, especially one which needs input from the design team

Comments

@euclaise
Copy link

Description

Custom themes stay enabled in incognito mode but dark-mode icons are enabled, thus when using a light theme, none of the icons are visible.

Steps to Reproduce

  1. Install a light theme from the Chrome store
  2. Open Incognito tab

Actual result:

image

Expected result:

The theme should be disabled, or the icons should stay the same way they were set in the settings page for general usage

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave | 0.57.6 Chromium: 71.0.3578.31 (Official Build) beta(64-bit)
Revision | c88fdf2a4ce19a713615ca4fbde7a0d0b5fe2363-refs/branch-heads/3578@{#427}
OS | Mac OS X
@euclaise
Copy link
Author

euclaise commented Nov 23, 2018 •
edited
Loading

Related but not identical: #1139

@tildelowengrimm tildelowengrimm added the design A design change, especially one which needs input from the design team label Nov 26, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Dec 2, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@rebron rebron moved this to P5 backlog in Front End May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design A design change, especially one which needs input from the design team
Projects
Front End
Status: P5 backlog
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tildelowengrimm @bbondy @rebron @euclaise