Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide ad earnings claim toast notification in Rewards panel if a promotion is OVER (no longer active) #22215

Closed
Miyayes opened this issue Apr 11, 2022 · 3 comments · Fixed by brave/brave-core#12971
Closed

Hide ad earnings claim toast notification in Rewards panel if a promotion is OVER (no longer active) #22215

Miyayes opened this issue Apr 11, 2022 · 3 comments · Fixed by brave/brave-core#12971
Assignees
@zenparsing
Labels
feature/rewards OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude rewards-2.0
Milestone
1.39.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Apr 11, 2022 •
edited
Loading

Description

Currently, if a promotion goes into OVER (or some other non-active state), the ad earnings claim notification remains in the Rewards panel and does not disappear like it does on the Rewards settings page. When clicked, it will just disappear with no other UX.

Solution

We should make it like the brave://rewards settings page (and Rewards NTP widget), which will display the ad earnings claim button in sync with what the promotion status/availability is.
@zenparsing zenparsing mentioned this issue Apr 11, 2022
Merged
25 tasks
@zenparsing zenparsing added this to the 1.39.x - Nightly milestone Apr 20, 2022
@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 28, 2022
@LaurenWags
Copy link
Member

LaurenWags commented Apr 28, 2022 •
edited
Loading

Verified with

Brave | 1.39.86 Chromium: 101.0.4951.41 (Official Build) beta (x86_64)
-- | --
Revision | 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS | macOS Version 12.3.1 (Build 21E258)
Test Case 1 - Staging UGP grant (claim from panel) - PASSED, follow up issue logged

From brave/brave-core#12971 (comment):

  • Open browser with a new profile pointed to Rewards staging.
  • Open the Rewards panel and enable rewards.
  • Dismiss the onboarding tour.
  • Do not click the "Claim" button in the UGP grant notification.
  • Close the Rewards panel.
  • Disconnect from the network.
  • Open the rewards panel.
  • Close the rewards panel.
  • Connect to the network.
  • Open the rewards panel.
    • Verify that the grant notification is displayed.
  • Claim the grant.
    • Verify that captcha claiming is successful.
    • At this point, the red bubble goes away.
Example Example Example Example
1 2 3 4
Test Case 3 - Staging UGP grant (claim from brave://rewards) - PASSED w/ follow up issue

From brave/brave-core#12971 (comment):

  • Open browser with a new profile pointed to Rewards staging.
  • Open the Rewards panel and enable rewards.
  • Dismiss the onboarding tour.
  • Do not click the "Claim" button in the UGP grant notification.
  • Close the Rewards panel.
  • Disconnect from the network.
  • Open the rewards panel.
  • Close the rewards panel.
  • Connect to the network.
  • Open the rewards panel.
    • Verify that the grant notification is displayed, dismiss the grant (click on "x")
  • Navigate to brave://rewards
  • Claim the grant from brave://rewards
    • Verify that captcha claiming is successful.
Example Example Example Example
1 2 3 4
Test Case 4 - Staging UGP grant (claim from NTP)- PASSED w/ follow up issue

From brave/brave-core#12971 (comment):

  • Open browser with a new profile pointed to Rewards staging.
  • Open the Rewards panel and enable rewards.
  • Dismiss the onboarding tour.
  • Do not click the "Claim" button in the UGP grant notification.
  • Close the Rewards panel.
  • Disconnect from the network.
  • Open the rewards panel.
  • Close the rewards panel.
  • Connect to the network.
  • Open the rewards panel.
    • Verify that the grant notification is displayed, dismiss the grant (click on "x")
  • Open NTP
  • Claim the grant from widget on NTP
    • Verify that captcha claiming is successful.
Example Example Example Example
1 2 3 4 
Brave | 1.39.87 Chromium: 101.0.4951.41 (Official Build) beta (x86_64)
-- | --
Revision | 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS | macOS Version 12.3.1 (Build 21E258)
Test Case 2 - Staging Ad grant - PASSED w/ follow up issue

From brave/brave-core#12971 (comment):

  1. Open browser with a new profile pointed to Rewards staging.
  2. Open the Rewards panel and enable rewards.
  3. Generate an Ad grant for the current rewards payment ID.
  4. Wait for the Ad grant to become available to the browser.
  5. Open the rewards panel.
  • Verify that the "Claim" notification is displayed.
  1. Do not click the "Claim" button.
  2. Close the Rewards panel.
  3. Have a server-side team member remove the Ad grant.
Step 4 Step 5 Step 5
Step 4 Step 5 Step 5a
  1. Wait for the grant to disappear from the rewards page.
  2. Open the rewards panel.
Step 9 Step 10 Step 10
9 10a 10b

@LaurenWags LaurenWags mentioned this issue Apr 29, 2022
Open
@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 2, 2022
@MadhaviSeelam
Copy link

MadhaviSeelam commented May 11, 2022 •
edited
Loading

Verification PASSED using

Brave 1.39.96 Chromium: 101.0.4951.54 (Official Build) beta (64-bit)
Revision 67da1aeb32cedd27634ca6634fb79cbd85d3f0ab-refs/branch-heads/4951@{#1126}
OS Windows 11 Version 21H2 (Build 22000.613)
Test Case 1 - Staging UGP grant (claim from panel) - PASSED, follow up issue logged

From brave/brave-core#12971 (comment):

  • Open browser with a new profile pointed to Rewards staging.
  • Open the Rewards panel and enable rewards.
  • Dismiss the onboarding tour.
  • Do not click the "Claim" button in the UGP grant notification.
  • Close the Rewards panel.
  • Disconnect from the network.
  • Open the rewards panel.
  • Close the rewards panel.
  • Connect to the network.
  • Open the rewards panel.
    • Verify that the grant notification is displayed.
  • Claim the grant.
    • Verify that captcha claiming is successful.
    • At this point, the red bubble goes away.
ex1 ex2 ex3 ex4 ex5
screenshot 1 screenshot 2 screenshot 3 screenshot 4 screenshot 5
Test Case 3 - Staging UGP grant (claim from brave://rewards) - PASSED w/ follow up issue

From brave/brave-core#12971 (comment):

  • Open browser with a new profile pointed to Rewards staging.
  • Open the Rewards panel and enable rewards.
  • Dismiss the onboarding tour.
  • Do not click the "Claim" button in the UGP grant notification.
  • Close the Rewards panel.
  • Disconnect from the network.
  • Open the rewards panel.
  • Close the rewards panel.
  • Connect to the network.
  • Open the rewards panel.
    • Verify that the grant notification is displayed, dismiss the grant (click on "x")
  • Navigate to brave://rewards
  • Claim the grant from brave://rewards
    • Verify that captcha claiming is successful.
ex1 ex2 ex3 ex4 ex5
screenshot 1 screenshot 2 screenshot 3 screenshot 4 screenshot 5
Test Case 4 - Staging UGP grant (claim from NTP)- PASSED w/ follow up issue From https://github.com/brave/brave-core/pull/12971#issue-1200460743:
  • Open browser with a new profile pointed to Rewards staging.
  • Open the Rewards panel and enable rewards.
  • Dismiss the onboarding tour.
  • Do not click the "Claim" button in the UGP grant notification.
  • Close the Rewards panel.
  • Disconnect from the network.
  • Open the rewards panel.
  • Close the rewards panel.
  • Connect to the network.
  • Open the rewards panel.
    • Verify that the grant notification is displayed, dismiss the grant (click on "x")
  • Open NTP
  • Claim the grant from widget on NTP
    • Verify that captcha claiming is successful.
ex1 ex2 ex3 ex4
Screenshot 1 Screenshot 2 Screenshot 3 Screenshot 4
Test Case 2 - Staging Ad grant - Skipped as server team is slammed

From brave/brave-core#12971 (comment):

  1. Open browser with a new profile pointed to Rewards staging.
  2. Open the Rewards panel and enable rewards.
  3. Generate an Ad grant for the current rewards payment ID.
  4. Wait for the Ad grant to become available to the browser.
  5. Open the rewards panel.
  • Verify that the "Claim" notification is displayed.
  1. Do not click the "Claim" button.
  2. Close the Rewards panel.
  3. Have a server-side team member remove the Ad grant.
  4. Wait for the grant to disappear from the rewards page.
  5. Open the rewards panel.

@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 11, 2022
@btlechowski
Copy link

btlechowski commented May 11, 2022 •
edited
Loading

Verification passed on

Brave 1.39.100 Chromium: 101.0.4951.61 (Official Build) beta (64-bit)
Revision 3b3633b32c491b4cba5fd7df3c7c0f628547cbcc-refs/branch-heads/4951@{#1189}
OS Ubuntu 18.04 LTS
Test Case 1 - Staging UGP grant (claim from panel) - PASSED, follow up issue logged

From brave/brave-core#12971 (comment):

  • Open browser with a new profile pointed to Rewards staging.
  • Open the Rewards panel and enable rewards.
  • Dismiss the onboarding tour.
  • Do not click the "Claim" button in the UGP grant notification.
  • Close the Rewards panel.
  • Disconnect from the network.
  • Open the rewards panel.
  • Close the rewards panel.
  • Connect to the network.
  • Open the rewards panel.
    • Verify that the grant notification is displayed.
  • Claim the grant.
    • Verify that captcha claiming is successful.
    • At this point, the red bubble goes away.

22215_1

Test Case 3 - Staging UGP grant (claim from brave://rewards) - PASSED w/ follow up issue

From brave/brave-core#12971 (comment):

  • Open browser with a new profile pointed to Rewards staging.
  • Open the Rewards panel and enable rewards.
  • Dismiss the onboarding tour.
  • Do not click the "Claim" button in the UGP grant notification.
  • Close the Rewards panel.
  • Disconnect from the network.
  • Open the rewards panel.
  • Close the rewards panel.
  • Connect to the network.
  • Open the rewards panel.
    • Verify that the grant notification is displayed, dismiss the grant (click on "x")
  • Navigate to brave://rewards
  • Claim the grant from brave://rewards
    • Verify that captcha claiming is successful.

22215_3

Test Case 4 - Staging UGP grant (claim from NTP)- PASSED w/ follow up issue

From brave/brave-core#12971 (comment):

  • Open browser with a new profile pointed to Rewards staging.
  • Open the Rewards panel and enable rewards.
  • Dismiss the onboarding tour.
  • Do not click the "Claim" button in the UGP grant notification.
  • Close the Rewards panel.
  • Disconnect from the network.
  • Open the rewards panel.
  • Close the rewards panel.
  • Connect to the network.
  • Open the rewards panel.
    • Verify that the grant notification is displayed, dismiss the grant (click on "x")
  • Open NTP
  • Claim the grant from widget on NTP
    • Verify that captcha claiming is successful.

22215_4

Test Case 2 - Staging Ad grant - Skipped as server team is slammed

From brave/brave-core#12971 (comment):

  1. Open browser with a new profile pointed to Rewards staging.
  2. Open the Rewards panel and enable rewards.
  3. Generate an Ad grant for the current rewards payment ID.
  4. Wait for the Ad grant to become available to the browser.
  5. Open the rewards panel.
  • Verify that the "Claim" notification is displayed.
  1. Do not click the "Claim" button.
  2. Close the Rewards panel.
  3. Have a server-side team member remove the Ad grant.
  4. Wait for the grant to disappear from the rewards page.
  5. Open the rewards panel.

@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zenparsing zenparsing

Labels
feature/rewards OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude rewards-2.0
Projects
None yet
Milestone
1.39.x - Release
Development

Successfully merging a pull request may close this issue.

Do not show Rewards panel notifications for inactive grants brave/brave-core
5 participants
@zenparsing @Miyayes @LaurenWags @btlechowski @MadhaviSeelam