-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[De-AMP] Add support for checking de_amp_enabled user pref in cosmetic js filter #22228
Comments
The above will require |
Verification
Pre-requisites: Mobile emulation via DevTools and set to Samsung Galaxy S8+
|
Verified
Pre-requisites: Mobile emulation via DevTools and set to Samsung Galaxy S8+
|
Verification PASSED on
Went through the STR/Cases outlined via brave/brave-core#12923 (comment).
|
Example |
Example |
Example |
Example |
---|---|---|---|
de-AMP Enabled
- ensured that
Auto-redirect AMP pages
was enabled viabrave://settings/privacy
- loaded
https://www.google.com
and then searched forTop Stories
- inspected the first article via
DevTools
and ensured thatjsaction
attribute wasn't appeared in the anchor link - clicked on the link and ensured that the de-AMP version of the website/news article was being loaded
Example |
Example |
Example |
---|---|---|
Quick note: I also tried https://www.google.ca
& https://www.google.co.uk
After speaking with @ShivanKaul, running through the mobile cases should be enough and tablet can be skipped. Tablet doesn't use AMP as much as the mobiles due to the view usually being |
Verification passed on
Pre-requisites: Mobile emulation via DevTools and set to Samsung Galaxy S8+
|
Add support for checking of DeAmp pref and flag in Cosmetic Filters JS Handlers, and add the boolean to the wrapping pre-init script.
This is done so that we can add a new scriptlet for removing
jsaction
HTML attributes from anchor tags on Google SERP.More details here: https://docs.google.com/document/d/1kvHbQMdE_vxmRWRz0LfAHzf6XoTT_pQXSwxth5rVhsk/edit#heading=h.okf43yiuecg5
The text was updated successfully, but these errors were encountered: