Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded shield advanced view is collapsed automatically in shield v2 #22281

Open
GeetaSarvadnya opened this issue Apr 13, 2022 · 4 comments
Open
Labels
feature/shields The overall Shields feature in Brave. OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Test-Plan-Specified QA/Yes

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 13, 2022

Description

Expanded shield advanced view is collapsed automatically in shield v2

Steps to Reproduce

  1. Clean profile 1.38.x
  2. Open a cnn.com
  3. Click on shield and expand the Advanced view by clicking on the Advanced controls
  4. Make sure the advanced view is expanded
  5. Click anywhere on the website to dismiss the shield panel
  6. Keep the browser idle for 2 or 3 mins
  7. Click on the shield
  8. Expanded shield advanced view is collapsed automatically

Actual result:

Expanded shield advanced view is collapsed automatically in shield v2

Expected result:

Expanded shield advanced view should not collapse automatically

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.38.90 Chromium: 100.0.4896.79 (Official Build) beta (64-bit)
Revision 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS Windows 10 Version 21H2 (Build 19044.1586)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @rebron @nullhook

@GeetaSarvadnya GeetaSarvadnya changed the title Expanded shield advanced view is collapsed automatically after 2 or 3 mins in shield v2 Expanded shield advanced view is collapsed automatically in shield v2 Apr 13, 2022
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Apr 15, 2022
@rebron rebron added priority/P5 Not scheduled. Don't anticipate work on this any time soon. and removed regression priority/P4 Planned work. We expect to get to it "soon". labels Apr 19, 2022
@rebron
Copy link
Collaborator

rebron commented Apr 19, 2022

Kicking the can down the road on this one. Considering wontfixing this one or actually maintaining state for the advanced panel.

@jtakeshi-nd
Copy link

The shield change to v2 is a pretty significant downgrade; the extra click is quite annoying when toggling Javascript off/on. If we don't have the option to stay with the (better) v1 interface, please at least let us have the option to have the advanced view open by default. Thanks!

@stephendonner
Copy link

The shield change to v2 is a pretty significant downgrade; the extra click is quite annoying when toggling Javascript off/on. If we don't have the option to stay with the (better) v1 interface, please at least let us have the option to have the advanced view open by default. Thanks!

That's coming in the next release, 1.43.x, coming ~ August 30th! https://github.com/brave/brave-browser/wiki/Brave-Release-Schedule#release-channel-dates

@wavesurf432
Copy link

The shield change to v2 is a pretty significant downgrade; the extra click is quite annoying when toggling Javascript off/on. If we don't have the option to stay with the (better) v1 interface, please at least let us have the option to have the advanced view open by default. Thanks!

That's coming in the next release, 1.43.x, coming ~ August 30th! https://github.com/brave/brave-browser/wiki/Brave-Release-Schedule#release-channel-dates

Great to hear, thanks.

@rebron rebron added this to General May 28, 2024
@rebron rebron moved this to P5 Backlog / waiting upstream in General May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields The overall Shields feature in Brave. OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Test-Plan-Specified QA/Yes
Projects
Status: P5 Backlog / waiting upstream
Development

No branches or pull requests

5 participants