Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The incorrect site favicon is shown in the shield panel when switching between the two sites #22284

Closed
GeetaSarvadnya opened this issue Apr 13, 2022 · 3 comments · Fixed by brave/brave-core#12994

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 13, 2022

Description

The incorrect site favicon is shown in the shield panel when switching between the two sites

Steps to Reproduce

  1. Clean profile 1.38.x or 1.39.x
  2. Open a cnn.com in tab 1 and theverge.com in tab2
  3. Open the shield in tab2 and ensure the correct site favicon is shown for theverge.com
  4. Open the shield in tab1 and check the site favicon for cnn.com, the site favicon is shown from the tab 2 which is incorrect

Note: reload the site fixes the issue

Actual result:

The incorrect site favicon is shown in the shield panel when switching between the two sites

favicon changes for a site in shiled when switch between the tabs

image

Expected result:

The correct site favicon should be shown in the shield panel when switching between the two sites

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.38.90 Chromium: 100.0.4896.79 (Official Build) beta (64-bit)
Revision 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS Windows 10 Version 21H2 (Build 19044.1586)
## Version/Channel Information:
  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @rebron @nullhook

@kjozwiak
Copy link
Member

Above requires 1.38.102 or higher for 1.38.x verification.

@GeetaSarvadnya
Copy link
Author

Verification PASSED on


Brave | 1.38.103 Chromium: 100.0.4896.127 (Official Build) beta (64-bit)
-- | --
Revision | ff0d0695743e65305d7194f9bd309e5e1c824aa0-refs/branch-heads/4896_88@{#4}
OS | Windows 10 Version 21H2 (Build 19044.1645)

  • Verified the STR from the description and ensured the shield panel is showing up the correct site favicon when switching between the two sites.

@stephendonner
Copy link

Verified PASSED using

Brave 1.38.103 Chromium: 100.0.4896.127 (Official Build) beta (x86_64)
Revision ff0d0695743e65305d7194f9bd309e5e1c824aa0-refs/branch-heads/4896_88@{#4}
OS macOS Version 11.6.5 (Build 20G527)

Confirmed the Shields panel shows the correct site favicon when switching between two sites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants