Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block scripts heading label should read Blocked scripts #22364

Closed
Tracked by #22546
stephendonner opened this issue Apr 17, 2022 · 5 comments
Closed
Tracked by #22546

Block scripts heading label should read Blocked scripts #22364

stephendonner opened this issue Apr 17, 2022 · 5 comments
Assignees
Labels
feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. needs-text-change This change requires some careful wording. OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@stephendonner
Copy link

stephendonner commented Apr 17, 2022

Description

Steps to Reproduce

  1. install 1.39.65
  2. launch Brave
  3. load cnn.com
  4. click on the Shields icon in the URL bar
  5. click Advanced controls
  6. click to toggle Block scripts to ON
  7. click on the blurple number to the right of Block scripts

Actual result:

10 Block scripts

Screen Shot 2022-04-17 at 2 46 07 AM

Expected result:

10 Blocked scripts

Screen Shot 2022-04-17 at 2 44 09 AM

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.39.65 Chromium: 101.0.4951.34 (Official Build) nightly (x86_64)
Revision 8f93af5d759634c5256b65997dedd138ed60992f-refs/branch-heads/4951@{#710}
OS macOS Version 11.6.5 (Build 20G527)

cc @nullhook @rmcfadden3 @jenn-rhim @MadhaviSeelam @GeetaSarvadnya

@stephendonner stephendonner added feature/shields The overall Shields feature in Brave. QA/Yes QA/Test-Plan-Specified feature/shields/panel Front-end design and functionality of the Shields panel. OS/Desktop labels Apr 17, 2022
@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". polish Nice to have — usually related to front-end/visual tasks labels Apr 22, 2022
@rebron rebron mentioned this issue Apr 25, 2022
7 tasks
@rebron rebron added the needs-text-change This change requires some careful wording. label Apr 26, 2022
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Apr 26, 2022
@rebron
Copy link
Collaborator

rebron commented Jun 1, 2022

Closed with brave/brave-core#13209

@rebron rebron closed this as completed Jun 1, 2022
@rebron rebron added this to the 1.41.x - Nightly milestone Jun 1, 2022
@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.41.40 Chromium: 102.0.5005.78 (Official Build) nightly (x86_64)
Revision df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS macOS Version 12.5 (Build 21G5037d)

Followed my original steps to reproduce.

Confirmed it now reads 10 Blocked scripts

example example
Screen Shot 2022-06-06 at 5 35 27 PM Screen Shot 2022-06-06 at 5 35 31 PM

@stephendonner stephendonner changed the title Block scripts heading label should read Blocked scripts Block scripts heading label should read Blocked scripts Jun 9, 2022
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.41.65 Chromium: 103.0.5060.42 (Official Build) nightly (64-bit)
-- | --
Revision | de0d840bf9439c31bd86bf74f065c31fdf9b208d-refs/branch-heads/5060@{#667}
OS | Windows 11 Version 21H2 (Build 22000.739)

Followed original steps and reproduced in 1.39.122

Confirmed it now reads 10 Blocked scripts

1.39.122 1.41.65
image image

@rmcfadden3
Copy link

Will defer to @stephendonner on this one, but now that I see it in context, I wonder if this should actually read "XX scripts blocked"

(note no capitalization on the "s" or "b" and also ordering of words reversed)

@stephendonner
Copy link
Author

stephendonner commented Jun 23, 2022

Will defer to @stephendonner on this one, but now that I see it in context, I wonder if this should actually read "XX scripts blocked"

(note no capitalization on the "s" or "b" and also ordering of words reversed)

Sounds good to me; I'll file a followup issue and cross-reference here, for posterity 👍 (We should re-evaluate grammar and punctuation for the other categories, while we're at it.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. needs-text-change This change requires some careful wording. OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Development

No branches or pull requests

5 participants