Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tooltip for VPN icon #22626

Closed
stephendonner opened this issue Apr 29, 2022 · 2 comments · Fixed by brave/brave-core#15592
Closed

Missing tooltip for VPN icon #22626

stephendonner opened this issue Apr 29, 2022 · 2 comments · Fixed by brave/brave-core#15592

Comments

@stephendonner
Copy link

Description

Missing tooltip for VPN icon

Steps to Reproduce

  1. install 1.39.86
  2. launch Brave
  3. set brave://flags/#brave-vpn to Enabled
  4. click on Relaunch
  5. hover over the VPN icon in the browser toolbar

Actual result:

Nothing happens - no tooltip on hover

Screen Shot 2022-04-29 at 10 05 33 AM

Expected result:

Tooltip - either static or dynamic (based on VPN-connection state)

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.39.86 Chromium: 101.0.4951.41 (Official Build) beta (x86_64)
Revision 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS macOS Version 11.6.5 (Build 20G527)

@aguscruiz @rebron

@kjozwiak
Copy link
Member

The above requires 1.46.83 or higher for 1.46.x verification 👍

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.46.86 Chromium: 107.0.5304.91 (Official Build) beta (x86_64)
Revision 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS macOS Version 11.7.1 (Build 20G918)

Steps:

  1. installed 1.46.86
  2. launched Brave
  3. opened brave://flags
  4. set SDK and VPN flags to Enabled
  5. clicked Relaunch
  6. loaded account.bravesoftware.com
  7. purchased Brave Firewall & VPN
  8. clicked on Refresh Brave VPN
  9. hovered over the VPN button on the browser toolbar
  10. confirmed it read Brave Firewall & VPN: Disconnected
  11. connected to VPN
  12. hovered over the VPN button on the browser toolbar
  13. confirmed it read Brave Firewall & VPN: Connected
disconnected connected
Screen Shot 2022-10-31 at 9 31 03 AM Screen Shot 2022-10-31 at 9 31 21 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants