Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Wallet as default wallet can be bypassed by extensions #22678

Closed
bbondy opened this issue May 3, 2022 · 2 comments · Fixed by brave/brave-core#13240
Closed

Brave Wallet as default wallet can be bypassed by extensions #22678

bbondy opened this issue May 3, 2022 · 2 comments · Fixed by brave/brave-core#13240
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@bbondy
Copy link
Member

bbondy commented May 3, 2022

When a user selects Brave Wallet explicitly in chrome://settings/wallet, other wallets should not be able to make it writable then overwrite it. Tally Ho was one such wallet doing that

Steps to reproduce:

Test 1

i) Install Tally Ho extension https://chrome.google.com/webstore/detail/tally-ho/eajafomhmkipbjmfmhebemolkcicgfmd
ii) Go to brave//settings/wallet and select Brave Wallet as the default wallet.
iii) Open a new tab to any site
iv) Open Console and type window.ethereum.enable()

Expected:
Brave Wallet should show up

Actual:
Tally Ho shows up

Test 2

Repeat with Brave Wallet (Prefer Extensions) as the default wallet.
i) Use a new tab
ii) Ensure that setting is set
iii) Open Console and type window.ethereum.enable()

Tally Ho should continue to show up

@bbondy bbondy added priority/P3 The next thing for us to work on. It'll ride the trains. OS/Android Fixes related to Android browser functionality OS/Desktop labels May 3, 2022
@bbondy bbondy self-assigned this May 3, 2022
@bbondy bbondy added this to Web3 May 3, 2022
@bbondy bbondy changed the title Brave Wallet as default wallet sometimes can get bypassed Brave Wallet as default wallet can be bypassed by extensions May 3, 2022
@bbondy bbondy moved this to Done in Web3 May 4, 2022
@bbondy bbondy added this to the 1.40.x - Nightly milestone May 10, 2022
@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label May 24, 2022
@srirambv
Copy link
Contributor

srirambv commented Jun 2, 2022

Brave 1.40.80 Chromium: 102.0.5005.78 (Official Build) beta (64-bit)
Revision df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS ☑️ Linux ☑️ Windows 11 Version 22H2
(Build 22621.1)
☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from issue description
  • Verified when wallet provider is set to Brave Wallet, running window.ethereum.enable() trigger opens Brave Panel
  • Verified when wallet provider is set to Brave Wallet (Prefer Extensions), running window.ethereum.enable() trigger opens Extension Popup and not Brave Wallet Panel
22678-Linux.mp4
22678-Windows.mov
22678-macOS.mov

@srirambv
Copy link
Contributor

Removing OS/Android label as there is no way to switch Wallet provider and extensions are not supported on Android

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants