Brave Wallet as default wallet can be bypassed by extensions #22678
Labels
feature/web3/wallet
Integrating Ethereum+ wallet support
OS/Desktop
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/include
Milestone
When a user selects Brave Wallet explicitly in chrome://settings/wallet, other wallets should not be able to make it writable then overwrite it. Tally Ho was one such wallet doing that
Steps to reproduce:
Test 1
i) Install Tally Ho extension https://chrome.google.com/webstore/detail/tally-ho/eajafomhmkipbjmfmhebemolkcicgfmd
ii) Go to brave//settings/wallet and select
Brave Wallet
as the default wallet.iii) Open a new tab to any site
iv) Open Console and type
window.ethereum.enable()
Expected:
Brave Wallet should show up
Actual:
Tally Ho shows up
Test 2
Repeat with Brave Wallet (Prefer Extensions) as the default wallet.
i) Use a new tab
ii) Ensure that setting is set
iii) Open Console and type
window.ethereum.enable()
Tally Ho should continue to show up
The text was updated successfully, but these errors were encountered: