-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contact technical support
form doesn't dismiss after submission
#22731
Comments
Contact technical support
form doesn't dismiss after submission
Not only does the dialog not auto-close upon submission, but it silently succeeds. We should definitely fix this before widening testing on desktop, as users might submit several duplicate reports. |
Some kind of "successful" message if we can't auto close the panel is definitely needed. |
@spylogsster mind grabbing this one? |
seems fixed in brave/brave-core#13486 |
++reproduced on Windows 10 x64 |
Mind double-checking again, @spylogsster ? I just tried with
and auto-closing isn't working for me. |
@stephendonner this fix will be in 1.41.38 |
Verified
|
Description
Contact technical support
form doesn't dismiss after submissionSteps to Reproduce
1.39.92
SKUs
flags and theVPN
flag inbrave://flags
Relaunch
account.brave.software
, initiate -- but don't successfully complete -- the Stripe purchase flow for Brave Firewall & VPNVPN
buttonEdit payment method
dialogContact technical support
Submit
Actual result:
Doesn't appear to have been sent, and the dialog remains (I think @mattmcalister has an existing issue filed on this aspect)
Thrown in the console is this; not sure if it's informative or showing an error:
[29679:259:0506/160342.445180:INFO:CONSOLE(683)] "function () { [native code] }", source: chrome-untrusted://vpn-panel.top-chrome/brave_vpn_panel.bundle.js (683)
Expected result:
If it sent successfully, there should be feedback indicating so, and at the least, close the dialog.
Reproduces how often:
100%
Brave version (brave://version info)
cc @bsclifton @nullhook @simonhong @mattmcalister @brave/qa-team
The text was updated successfully, but these errors were encountered: