Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact technical support form doesn't dismiss after submission #22731

Closed
stephendonner opened this issue May 6, 2022 · 8 comments · Fixed by brave/brave-core#13486
Closed

Comments

@stephendonner
Copy link

stephendonner commented May 6, 2022

Description

Contact technical support form doesn't dismiss after submission

Steps to Reproduce

  1. install 1.39.92
  2. launch Brave
  3. enable both SKUs flags and the VPN flag in brave://flags
  4. click to Relaunch
  5. on account.brave.software, initiate -- but don't successfully complete -- the Stripe purchase flow for Brave Firewall & VPN
  6. click on the VPN button
  7. you should now be on the Edit payment method dialog
  8. click on Contact technical support
  9. fill out the form
  10. click on Submit

Actual result:

Doesn't appear to have been sent, and the dialog remains (I think @mattmcalister has an existing issue filed on this aspect)

not-sent

Thrown in the console is this; not sure if it's informative or showing an error:

[29679:259:0506/160342.445180:INFO:CONSOLE(683)] "function () { [native code] }", source: chrome-untrusted://vpn-panel.top-chrome/brave_vpn_panel.bundle.js (683)

Expected result:

If it sent successfully, there should be feedback indicating so, and at the least, close the dialog.

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.39.92 Chromium: 101.0.4951.54 (Official Build) beta (x86_64)
Revision 67da1aeb32cedd27634ca6634fb79cbd85d3f0ab-refs/branch-heads/4951@{#1126}
OS macOS Version 11.6.5 (Build 20G527)

cc @bsclifton @nullhook @simonhong @mattmcalister @brave/qa-team

@stephendonner stephendonner changed the title Contact technical support form doesn't submit Contact technical support form doesn't dismiss May 6, 2022
@stephendonner stephendonner changed the title Contact technical support form doesn't dismiss Contact technical support form doesn't dismiss after submission May 7, 2022
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label May 9, 2022
@stephendonner
Copy link
Author

Not only does the dialog not auto-close upon submission, but it silently succeeds. We should definitely fix this before widening testing on desktop, as users might submit several duplicate reports.

@LaurenWags
Copy link
Member

LaurenWags commented May 23, 2022

++ @stephendonner

Some kind of "successful" message if we can't auto close the panel is definitely needed.

@stephendonner
Copy link
Author

@spylogsster mind grabbing this one?

@spylogsster
Copy link

seems fixed in brave/brave-core#13486

@GeetaSarvadnya
Copy link

++reproduced on Windows 10 x64

@stephendonner
Copy link
Author

Mind double-checking again, @spylogsster ?

I just tried with

Brave 1.41.37 Chromium: 102.0.5005.78 (Official Build) nightly (x86_64)
Revision df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS macOS Version 11.6.6 (Build 20G624)

and auto-closing isn't working for me.

@spylogsster
Copy link

@stephendonner this fix will be in 1.41.38

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.41.39 Chromium: 102.0.5005.78 (Official Build) nightly (x86_64)
Revision df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS macOS Version 11.6.6 (Build 20G624)

feedback-auto-close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants