-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should show connection-error message after disabling network #22754
Comments
Might be related to #22677; in any case, re-check after that fix lands. |
Reproduced with 1.39.106 on macOS M1 |
++reproduced with Windows 10 x64 - After reconnecting wifi/internet, unable to connect VPN until the browser is restarted |
Verified
|
Brave | 1.41.74 Chromium: 103.0.5060.53 (Official Build) beta (x86_64) |
---|---|
Revision | a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853} |
OS | macOS Version 12.5 (Build 21G5046c) |
Followed my original steps to reproduce.
Confirmed I got an error message while offline, although it's the incorrect/imprecise error about payment, rather than connection status.
I'll log a follow-up issue on the incorrect error dialog (Edit your payment
) appearing first when offline, then being replaced by the correct error dialog (Can't connect to server
).
Verification
Followed original steps |
Error message is shown as expected when WIFI is disconnected but VPN cannot be reconnected in the same session when WIFI is enabled. Logged follow up issue #24331 |
Test plan
See brave/brave-core#13593
Description
Should show connection-error message after disabling network
Steps to Reproduce
Try again
buttonActual result:
It just quickly toggles display from
Connecting
/Connected
toDisconnected
, without throwing up the error message about not being able to connect(Sorry, not the clearest video.)
Expected result:
We should see this error message:
Reproduces how often:
100%
Brave version (brave://version info)
cc @simonhong @bsclifton @mattmcalister @brave/qa-team
The text was updated successfully, but these errors were encountered: