Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync chain is deleted when relaunching browser in offline status #2278

Closed
darkdh opened this issue Nov 29, 2018 · 1 comment · Fixed by brave/brave-core#973
Closed

Sync chain is deleted when relaunching browser in offline status #2278

darkdh opened this issue Nov 29, 2018 · 1 comment · Fixed by brave/brave-core#973
Assignees
@darkdh
Labels
bug feature/sync priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release/blocking release-notes/exclude
Milestone
0.58.x - Release ...

Comments

@darkdh
Copy link
Member

darkdh commented Nov 29, 2018

Steps to reproduce

  1. Create a new sync chain on device A
  2. Make sure sync chain is created
  3. Quit browser
  4. Setting device A to offline (no internet access)
  5. Launch browser
  6. Previously created sync chain got deleted
@darkdh darkdh added bug release/blocking feature/sync priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/Yes labels Nov 29, 2018
@darkdh darkdh added this to the 0.57.x - Beta milestone Nov 29, 2018
@darkdh darkdh self-assigned this Nov 29, 2018
@darkdh darkdh mentioned this issue Nov 29, 2018
Merged
18 tasks
@bbondy bbondy modified the milestones: 0.57.x - Beta, 0.58.x - Dev Nov 29, 2018
@LaurenWags
Copy link
Member

LaurenWags commented Dec 11, 2018 •
edited by srirambv
Loading

Verified passed with

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X
  • Verified STR in description

Verification passed on

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows 7 x64

Used STR from OP

Verification passed on

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Linux
  • Verified sync was not reset when browser was launched offline

@kjozwiak kjozwiak mentioned this issue Jan 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkdh darkdh

Labels
bug feature/sync priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release/blocking release-notes/exclude
Projects
None yet
Milestone
0.58.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Handle offline cases for sync brave/brave-core
6 participants
@bbondy @kjozwiak @darkdh @srirambv @LaurenWags @btlechowski