Block script doesn't show all blocked items at once and lists irrelevant items blocked

[srirambv]

Description

Block script doesn't show all blocked items at once and lists irrelevant items blocked

Steps to Reproduce

1. Build from source (2e9c470)
2. Visit brianbondy.com in a new tab
3. Block scripts from shields, shows one entry for blocked item
4. Disable the blocked item and click apply
5. Two more blocked items show up which are not relevant

Actual result:

Blocked scripts on current muon browser for comparison

Expected result:

Should show all blocked items when block script is enabled and only block relevant items

Reproduces how often:

Easy

Brave version (about:brave info)

2e9c470

cc: @bbondy

[yrliou]

Above is the screenshot for the current result. The youtube.com entry won't be shown before we unblock script on brianbondy.com because it won't be loaded at all if script on brianbondy.com is blocked. So not showing brianbondy.com & youtube.com at once seems to be the expected result to me.

The two youtube scripts blocked also seem to be valid for me judging from the above screenshot of devtool. These two scripts are from the youtube iframe in this page.

[bbondy]

I think maybe just the UI is confusing because if I re-block on brianbondy.com scripts, then I expect for youtube to not show up in that case again, but the radio button is still there.

[yrliou]

QA note: Please see the test plan specified in brave/brave-core#494, thanks!

[LaurenWags]

Verified passed with

Brave	0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision	ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS	Mac OS X

• Using test plan from Fix per-origin noScript brave-core#494

Verification Passed on

Brave	0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision	28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS	Linux

Verification passes on

Brave	0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision	28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS	Windows 7