Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPN can't be reconnected in the same session when internet/wifi is disconnected and reconnected #23081

Closed
GeetaSarvadnya opened this issue May 26, 2022 · 3 comments · Fixed by brave/brave-core#13867

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 26, 2022

Description

VPN can't be reconnected in the same session when internet/wifi is reconnected

Steps to Reproduce

  1. Clean profile 1.40.75
  2. Follow the steps to connect VPN
  3. Disconnect the WIFI/Internet
  4. Confirm that VPN gets disconnected
  5. Try to connect VPN via Browser VPN and ensure you get the Can't connect to server error popup modal
  6. Reconnect the WIFI/Internet
  7. Click on the Try again button in the Can't connect to server error popup modal
  8. Nothing happens, unable to reconnect the VPN in the same session
  9. Restart the browser
  10. Reconnect the VPN via VPN or hamburger menu, VPN gets connected successfully in the 2nd browser session

Actual result:

VPN can't be reconnected in the same session when internet/wifi is reconnected

VPN reconnect

Expected result:

Should be able to reconnect the VPN in the same browser session

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.40.75 Chromium: 102.0.5005.61 (Official Build) beta (64-bit)
Revision 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS Windows 10 Version 21H2 (Build 19044.1706)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? NO

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @spylogsster @bsclifton @simonhong

@GeetaSarvadnya GeetaSarvadnya changed the title VPN can't be reconnected in the same session when internet/wifi is reconnected VPN can't be reconnected in the same session when internet/wifi is disconnected and reconnected May 30, 2022
@spylogsster spylogsster self-assigned this Jun 3, 2022
@GeetaSarvadnya
Copy link
Author

@spylogsster The issue is still reproducible in 140.87

@stephendonner
Copy link

stephendonner commented Jul 16, 2022

Verified PASSED using

Brave 1.42.67 Chromium: 103.0.5060.114 (Official Build) beta (x86_64)
Revision a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS macOS Version 13.0 (Build 22A5295i)

Steps:

  1. installed 1.42.67
  2. launch Brave
  3. enable SKU SDK and VPN features via brave://flags
  4. set up VPN from staging (account.bravesoftware.com)
  5. disconnect the Wi-Fi/Internet
  6. confirm that BraveVPN gets disconnected
  7. try to connect BraveVPN via the browser's VPN button and ensure you get the Can't connect to server error-popup modal
  8. reconnect the Wi-Fi/Internet
  9. click on the Try again button in the Can't connect to server error-popup modal

23081


Verification PASSED on

Brave | 1.42.78 Chromium: 103.0.5060.134 (Official Build) beta (64-bit)
-- | --
Revision | 8ec6fce403b3feb0869b0732eda8bd95011d333c-refs/branch-heads/5060@{#1262}
OS | Windows 10 Version 21H2 (Build 19044.1826)

Issue is still reproducible in windows 1.42.78 Logged an follow up issue #24331

@LaurenWags
Copy link
Member

Updated label to release-notes/exclude after conferring with @rebron as Brave VPN is not part of the 1.42.x release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment