Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPN sell dialog clips bottom of VPN button #23106

Open
stephendonner opened this issue May 27, 2022 · 0 comments
Open

VPN sell dialog clips bottom of VPN button #23106

stephendonner opened this issue May 27, 2022 · 0 comments
Labels
bug feature/vpn OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Test-Plan-Specified QA/Yes

Comments

@stephendonner
Copy link

Description

VPN sell dialog clips bottom of VPN button

credit to @anthonypkeane keen's eyes for the find

Steps to Reproduce

  1. install 1.41.19
  2. launch Brave
  3. enable requisite VPN and SKUs flags via brave://flags
  4. click Relaunch
  5. click on the VPN button on the browser toolbar
  6. examine the lack of spacing between the VPN button and its flyout doorhanger menu

Actual result:

The VPN button's bottom border is clipped by its flyout doorhanger menu

no clipping clipping no clipping clipping
Screen Shot 2022-05-27 at 4 10 27 AM Screen Shot 2022-05-27 at 4 24 18 AM Screen Shot 2022-05-27 at 4 25 53 AM Screen Shot 2022-05-27 at 4 26 08 AM

Expected result:

see no clipping, above

Reproduces how often:

Brave version (brave://version info)

Brave 1.41.19 Chromium: 102.0.5005.61 (Official Build) nightly (x86_64)
Revision 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS macOS Version 11.6.6 (Build 20G624)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@bsclifton bsclifton added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/vpn OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Test-Plan-Specified QA/Yes
Projects
None yet
Development

No branches or pull requests

2 participants