Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use checked arithmetic in GenerateP3AMessage #23157

Open
rillian opened this issue May 31, 2022 · 0 comments
Open

Use checked arithmetic in GenerateP3AMessage #23157

rillian opened this issue May 31, 2022 · 0 comments
Assignees
@rillian
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude

Comments

@rillian
Copy link

rillian commented May 31, 2022

Description

The buffer size calculation in the overflow guard in GenerateP3AMessage could itself overflow if the input state is corrupt. While safe in normal usage, we should be defensive and use checked arithmetic for this calculation.

Followup to #23147
@rillian rillian added QA/No release-notes/exclude OS/Android Fixes related to Android browser functionality OS/Desktop labels May 31, 2022
@rillian rillian self-assigned this May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rillian rillian

Labels
OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rillian