Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DApps: remove beta from a Wallet item menu #23238

Closed
SergeyZhukovsky opened this issue Jun 3, 2022 · 4 comments · Fixed by brave/brave-core#13602
Closed

DApps: remove beta from a Wallet item menu #23238

SergeyZhukovsky opened this issue Jun 3, 2022 · 4 comments · Fixed by brave/brave-core#13602
Assignees
@SergeyZhukovsky
Labels
feature/web3/wallet/dapps feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.40.x - Release

Comments

@SergeyZhukovsky
Copy link
Member

just leave Wallet there.
@SergeyZhukovsky SergeyZhukovsky added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality feature/web3/wallet/dapps labels Jun 3, 2022
@SergeyZhukovsky SergeyZhukovsky self-assigned this Jun 3, 2022
@SergeyZhukovsky SergeyZhukovsky moved this to In Progress in Web3 Jun 3, 2022
@SergeyZhukovsky SergeyZhukovsky mentioned this issue Jun 3, 2022
Merged
25 tasks
@SergeyZhukovsky SergeyZhukovsky added this to the 1.41.x - Nightly milestone Jun 3, 2022
Repository owner moved this from In Progress to Done in Web3 Jun 3, 2022
@brave-builds brave-builds mentioned this issue Jun 3, 2022
Merged
7 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Jun 7, 2022

The above requires 1.40.88 or higher for 1.40.x verification 👍

@srirambv
Copy link
Contributor

This seems broken on 1.40.101 build
image

@srirambv
Copy link
Contributor

This seems to be an issue with non-US regions. With device locale set to US, it shows correctly

@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.40.105 x64 build

  • Verified the word (beta) is removed from menu entry for Wallet
  • Verified changing locale to non-US region also show Wallet instead of Wallet (beta)
Oppo Reno 5 (Android 12) Samsung Tab A (Android 10)

@kjozwiak kjozwiak mentioned this issue Jun 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SergeyZhukovsky SergeyZhukovsky

Labels
feature/web3/wallet/dapps feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.40.x - Release
Development

Successfully merging a pull request may close this issue.

Remove beta from Wallet's menu on Android brave/brave-core
3 participants
@kjozwiak @SergeyZhukovsky @srirambv