-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce Language fingerprinting preference causes website to break #23306
Labels
Milestone
Comments
ShivanKaul
added
OS/Android
Fixes related to Android browser functionality
OS/Desktop
labels
Jun 7, 2022
25 tasks
Verified
|
Brave | 1.41.65 Chromium: 103.0.5060.42 (Official Build) nightly (x86_64) |
---|---|
Revision | de0d840bf9439c31bd86bf74f065c31fdf9b208d-refs/branch-heads/5060@{#667} |
OS | macOS Version 11.6.7 (Build 20G630) |
Reproduced using:
Brave | 1.41.39 Chromium: 102.0.5005.78 (Official Build) nightly (x86_64) |
---|---|
Revision | df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3} |
OS | macOS Version 11.6.7 (Build 20G630) |
Steps:
- installed Brave
- launched Brave
- loaded
https://ticketweb.ca
- confirmed page rendered
- opened
brave://settings/shields
- confirmed
Prevent sites from fingerprinting me based on my language preferences
was toggled toON
by default
1.41.39 |
brave://settings/shields |
---|---|
1.41.65 |
brave://settings/shields |
---|---|
Verification
Couldn't reproduce in older builds Beta and Nightly (1.40.100 Chromium: 102.0.5005.125 beta, 1.41.39 Chromium: 102.0.5005.78) Page rendered as expected in Steps:
|
Verified
|
Brave | 1.41.84 Chromium: 103.0.5060.66 (Official Build) beta (64-bit) |
---|---|
Revision | 20b1569438a85e631d15e83eb355e3e326e5da6f-refs/branch-heads/5060@{#1066} |
OS | Linux |
NOTE: until things are a bit more smoothed out, this isn't enabled by default any longer, in the client, and is instead now controlled by a Griffin study.
Confirmed:
- pref is now
OFF
by default (see above) ticketweb.ca
displays fine even withPrevent sites from fingerprinting me based on my language preferences
toggled toON
1.41.84 |
brave://settings/shields |
---|---|
Also, could NOT reproduce the issue in 1.41.39
:
1.41.39 |
brave://settings/shields |
---|---|
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Navigating to https://www.ticketweb.ca/ with Reduce Language fingerprinting preference on results in an empty page. With the pref turned off, page loads fine.
Steps to Reproduce
Actual result:
Expected result:
Reproduces how often:
It seems like the issue is a lack of a weight being sent in the
Accept-Language
header when Reduce Language pref is turned on. There's a 1/6 chance that it will be set to nothing: https://github.com/brave/brave-core/blob/master/browser/brave_shields/reduce_language_navigation_throttle.cc#L98My
Accept-Language
header isen-US
with Reduce Language on anden-US,en;q=0.9
with it off.The text was updated successfully, but these errors were encountered: