Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't hide full asset while loading balances #23436

Closed
Douglashdaniel opened this issue Jun 14, 2022 · 2 comments · Fixed by brave/brave-core#13768
Closed

Don't hide full asset while loading balances #23436

Douglashdaniel opened this issue Jun 14, 2022 · 2 comments · Fixed by brave/brave-core#13768
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.41.x - Release

Comments

@Douglashdaniel
Copy link

Description

Currently we have a Skeleton loading view for Assets that is continuously displayed until the balance is returned.
We should at least show the asset while the balance is still being returned so it's not confusing of what asset is still loading.

Screen Shot 2022-06-13 at 9 56 30 PM
@Douglashdaniel Douglashdaniel added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Jun 14, 2022
@Douglashdaniel Douglashdaniel self-assigned this Jun 14, 2022
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Jun 14, 2022
@Douglashdaniel Douglashdaniel mentioned this issue Jun 14, 2022
Merged
25 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Jun 14, 2022
@Douglashdaniel Douglashdaniel added this to the 1.41.x - Nightly milestone Jun 14, 2022
Repository owner moved this from In Review to Done in Web3 Jun 14, 2022
@Uni-verse
Copy link
Contributor

Verification PASSED using

Brave	1.41.91 Chromium: 103.0.5060.114 (Official Build) beta (64-bit) 
Revision	a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS	Windows 11 Version 21H2 (Build 22000.318)

Acceptance Criteria:

PASS - Show the asset while the balance is still being returned so it's not confusing of what asset is still loading.
PASS - Skeleton animation should only impact the balance in Portfolio and Accounts Pages

Accounts Page Portfolio (Solana) Portfolio (BSC)
Screen Shot 2022-07-08 at 1 00 53 PM Screen Shot 2022-07-08 at 12 59 28 PM Screen Shot 2022-07-08 at 12 53 23 PM

@Uni-verse
Copy link
Contributor

Uni-verse commented Jul 8, 2022 •
edited
Loading

Verification PASSED using

Brave	1.41.91 Chromium: 103.0.5060.114 (Official Build) beta (64-bit) 
Revision	a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS	Linux (Debian version 11)

Acceptance Criteria:

PASS - Show the asset while the balance is still being returned so it's not confusing of what asset is still loading.
PASS - Skeleton animation should only impact the balance in Portfolio and Accounts Pages

Accounts Page Portfolio
Screen Shot 2022-07-08 at 1 43 07 PM Screen Shot 2022-07-08 at 1 35 43 PM

@LaurenWags LaurenWags mentioned this issue Jul 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.41.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Show Asset Info While Loading Balances brave/brave-core
2 participants
@Uni-verse @Douglashdaniel